Clean up jsx grammar and comment jsx code.

The jsx grammar only needs to take care of `<>` and `</>` and `</` and `/>`.
The `<` and `>` cases are handled via semantic highlighting.
And the ids are handled via semantic highlighting just like ids in any other context.

Author: cristianoc

analysis/src/SemanticTokens.ml

@@ -217,6 +217,14 @@ let parser ~debug ~emitter ~path =
       Ast_mapper.default_mapper.expr mapper e
     | Pexp_apply ({pexp_desc = Pexp_ident lident; pexp_loc}, args)
       when Res_parsetree_viewer.isJsxExpression e ->
+      (*
+         Angled brackets:
+          - These are handled in the grammar:  <>  </>  </  />
+          - Here we handle `<` and `>`
+
+         Component names:
+          - handled like other Longitent.t, except lowercase id is marked Token.JsxLowercase
+      *)
       let rec isSelfClosing args =
         match args with
         | [] -> false
@@ -231,7 +239,7 @@ let parser ~debug ~emitter ~path =
           true
         | _ :: rest -> isSelfClosing rest
       in
-      emitter
+      emitter (* --> <div..  *)
       |> emitJsxTag ~debug ~name:"<"
            ~pos:
              (let pos = Utils.tupleOfLexing e.pexp_loc.loc_start in
@@ -262,7 +270,7 @@ let parser ~debug ~emitter ~path =
               ~pos:
                 (let pos = Utils.tupleOfLexing e.pexp_loc.loc_end in
                  (fst pos, snd pos - 1))));
-      (* only process again arguments, not the jsx label *)
+
       let _ = args |> List.map (fun (_lbl, arg) -> mapper.expr mapper arg) in
       e
     | Pexp_apply

grammars/rescript.tmLanguage.json

@@ -364,45 +364,8 @@
       ]
     },
     "jsx": {
-      "patterns": [
-        {
-          "match": "<>|</>|/>",
-          "name": "punctuation.definition.tag"
-        },
-        {
-          "match": "</([A-Z_][0-9a-zA-Z_]*)",
-          "captures": {
-            "0": {
-              "name": "punctuation.definition.tag"
-            },
-            "1": {
-              "name": "entity.name.namespace"
-            }
-          }
-        },
-        {
-          "match": "</([a-z_][0-9a-zA-Z_]*)",
-          "captures": {
-            "0": {
-              "name": "punctuation.definition.tag"
-            },
-            "1": {
-              "name": "variable"
-            }
-          }
-        },
-        {
-          "match": "<([A-Z_][0-9a-zA-Z_]*)",
-          "captures": {
-            "0": {
-              "name": "punctuation.definition.tag"
-            },
-            "1": {
-              "name": "entity.name.namespace"
-            }
-          }
-        }
-      ]
+      "match": "<>|</>|</|/>",
+      "name": "punctuation.definition.tag"
     },
     "openOrIncludeModule": {
       "patterns": [