Fix issue whith completing x= in JSX.

When completing `x=`, if the following contains `name=...`, then the parser interprets it as `x=name`.

Now detect that the cursor is after the  label `x` but before `name`, and don;t interpret the situation as label completion.

Author: cristianoc

analysis/src/Commands.ml

@@ -25,6 +25,10 @@ let findJsxPropsCompletable ~jsxProps ~endPos ~posBeforeCursor ~posAfterCompName
     | prop :: rest ->
       if prop.posStart <= posBeforeCursor && posBeforeCursor < prop.posEnd then
         Some (PartialParser.Cjsx (jsxProps.componentPath, prop.name, allLabels))
+      else if
+        prop.posEnd <= posBeforeCursor
+        && posBeforeCursor < Loc.start prop.exp.pexp_loc
+      then None
       else if prop.exp.pexp_loc |> Loc.hasPos ~pos:posBeforeCursor then None
       else loop rest
     | [] ->
@@ -99,7 +103,7 @@ let extractJsxProps ~text ~(compName : Longident.t Location.loc) ~args =
         ( PartialParser.positionToOffset text ePosStart,
           PartialParser.positionToOffset text ePosEnd )
       with
-      | Some offsetStart, Some offsetEnd ->
+      | Some offsetStart, Some offsetEnd when not eProp.pexp_loc.loc_ghost ->
         let label = String.sub text lastOffset (offsetStart - lastOffset) in
         let labelPos =
           match extractLabelPos ~pos:lastPos ~i:0 label with

analysis/tests/src/Jsx.res

@@ -98,10 +98,15 @@ let _ =
     name=""
   />
 
-
 let _ =
   <div
   // ^com x=Outer.Inner.
+    name=""  />
+
+
+let _ =
+  <div
+  // ^com x=
     name=""
   />
 

analysis/tests/src/expected/Jsx.res.txt

@@ -396,11 +396,11 @@ Completable: Cpath Value[Outer, Inner, h]
     "documentation": null
   }]
 
-Complete tests/src/Jsx.res 102:5
-posCursor:[103:15] posNoWhite:[103:14] Found expr:[102:3->104:9]
-JSX <div:[102:3->102:6] x[103:1->103:2]=...[103:3->104:8]> _children:None
-posCursor:[103:15] posNoWhite:[103:14] Found expr:[103:3->104:8]
-Pexp_ident Outer.Inner.name:[103:3->104:8]
+Complete tests/src/Jsx.res 101:5
+posCursor:[102:15] posNoWhite:[102:14] Found expr:[101:3->103:9]
+JSX <div:[101:3->101:6] x[102:1->102:2]=...[102:3->103:8]> _children:None
+posCursor:[102:15] posNoWhite:[102:14] Found expr:[102:3->103:8]
+Pexp_ident Outer.Inner.name:[102:3->103:8]
 Id breaks up. New path:Outer.Inner.
 Completable: Cpath Value[Outer, Inner, ""]
 [{
@@ -411,3 +411,8 @@ Completable: Cpath Value[Outer, Inner, ""]
     "documentation": null
   }]
 
+Complete tests/src/Jsx.res 107:5
+posCursor:[108:3] posNoWhite:[108:2] Found expr:[107:3->109:9]
+JSX <div:[107:3->107:6] x[108:1->108:2]=...[109:4->109:8]> _children:None
+[]
+