Backward-compatible check for optional fields.

Author: cristianoc

analysis/tests/src/expected/CompletionExpressions.res.txt

@@ -471,27 +471,13 @@ posCursor:[108:57] posNoWhite:[108:56] Found expr:[108:11->108:60]
 Pexp_apply ...[108:11->108:42] (...[108:43->108:60])
 Completable: Cexpression CArgument Value[fnTakingRecordWithOptionalField]($0)->recordField(someOptField)
 [{
-    "label": "None",
-    "kind": 4,
-    "tags": [],
-    "detail": "bool",
-    "documentation": null
-  }, {
-    "label": "Some(_)",
-    "kind": 4,
-    "tags": [],
-    "detail": "bool",
-    "documentation": null,
-    "insertText": "Some(${1:_})",
-    "insertTextFormat": 2
-  }, {
-    "label": "Some(true)",
+    "label": "true",
     "kind": 4,
     "tags": [],
     "detail": "bool",
     "documentation": null
   }, {
-    "label": "Some(false)",
+    "label": "false",
     "kind": 4,
     "tags": [],
     "detail": "bool",
@@ -771,7 +757,7 @@ Completable: Cpath Value[fff].someOpt
     "label": "someOptField",
     "kind": 5,
     "tags": [],
-    "detail": "someOptField: option<bool>\n\ntype recordWithOptionalField = {\n  someField: int,\n  someOptField?: bool,\n}",
+    "detail": "someOptField?: bool\n\ntype recordWithOptionalField = {\n  someField: int,\n  someOptField?: bool,\n}",
     "documentation": null
   }]
 

analysis/tests/src/expected/Destructuring.res.txt

@@ -68,10 +68,10 @@ Completable: Cpattern Value[x]->recordBody
     "detail": "someField: int\n\nrecordWithOptField",
     "documentation": null
   }, {
-    "label": "someOptField",
+    "label": "?someOptField",
     "kind": 5,
     "tags": [],
-    "detail": "someOptField: option<bool>\n\nrecordWithOptField",
-    "documentation": null
+    "detail": "?someOptField: option<bool>\n\nrecordWithOptField",
+    "documentation": {"kind": "markdown", "value": "someOptField is an optional field, and needs to be destructured using '?'."}
   }]
 

analysis/vendor/res_outcome_printer/res_parsetree_viewer.ml

@@ -348,7 +348,7 @@ let isIfLetExpr expr =
 let rec hasOptionalAttribute attrs =
   match attrs with
   | [] -> false
-  | ({Location.txt = "res.optional"}, _) :: _ -> true
+  | ({Location.txt = "ns.optional" | "res.optional"}, _) :: _ -> true
   | _ :: attrs -> hasOptionalAttribute attrs
 
 let hasAttributes attrs =