field name, and fix double escaping

Author: zth

analysis/src/DocExtraction.ml

@@ -129,8 +129,7 @@ end
 let stringifyDocstrings docstrings =
   let open Protocol in
   docstrings
-  |> List.map (fun docstring ->
-         docstring |> String.trim |> Json.escape |> wrapInQuotes)
+  |> List.map (fun docstring -> docstring |> String.trim |> wrapInQuotes)
   |> array
 
 let stringifyLinkables ?(indentation = 0)
@@ -181,7 +180,7 @@ let stringifyDetail ?(indentation = 0) ~originalEnv (detail : docItemDetail) =
     stringifyObject ~startOnNewline:true ~indentation
       [
         ("kind", Some (wrapInQuotes "variant"));
-        ( "fieldDocs",
+        ( "constructorDocs",
           Some
             (constructorDocs
             |> List.map (fun constructorDoc ->

analysis/tests/src/expected/DocExtractionRes.res.txt

@@ -33,7 +33,7 @@ extracting docs for src/DocExtractionRes.res
     "kind": "value",
     "name": "make",
     "signature": "let make: string => t",
-    "docstrings": ["Create stuff.\\n\\n```rescript example\\nlet stuff = make(\\\"My name\\\")\\n```"],
+    "docstrings": ["Create stuff.\n\n```rescript example\nlet stuff = make(\"My name\")\n```"],
     "linkables": [{
         "linkId": "DocExtractionRes.t",
         "name": "t",
@@ -74,7 +74,7 @@ extracting docs for src/DocExtractionRes.res
         "detail": 
         {
           "kind": "variant",
-          "fieldDocs": [
+          "constructorDocs": [
           {
             "constructorName": "Started",
             "docstrings": ["If this is started or not"],
@@ -167,7 +167,7 @@ extracting docs for src/DocExtractionRes.res
         "detail": 
         {
           "kind": "variant",
-          "fieldDocs": [
+          "constructorDocs": [
           {
             "constructorName": "SomeStuff",
             "docstrings": ["This has inline records..."],