Do not report empty modules when transitive reporting is off.

As the only way for a module to be dead would be for it to be empty.

Author: cristianoc

analysis/reanalyze/examples/deadcode/expected/deadcode.txt

@@ -2662,10 +2662,6 @@ File References
   File "OptArg.res", line 1, characters 1-49
   optional argument z of function foo is never used
 
-  Warning Dead Module
-  File "AutoAnnotate.res", line 0, characters 1-1
-  AutoAnnotate is a dead module as all its items are dead.
-
   Warning Dead Type
   File "AutoAnnotate.res", line 1, characters 16-22
   variant.R is a variant case which is never constructed
@@ -2708,10 +2704,6 @@ File References
   <-- line 15
     | @dead("annotatedVariant.R4") R4(r4)
 
-  Warning Dead Module
-  File "BucklescriptAnnotations.res", line 0, characters 1-1
-  BucklescriptAnnotations is a dead module as all its items are dead.
-
   Warning Dead Value
   File "BucklescriptAnnotations.res", line 25, characters 1-71
   bar is never used
@@ -2730,20 +2722,12 @@ File References
   <-- line 8
   @dead("eToplevel") let eToplevel = Etoplevel
 
-  Warning Dead Module
-  File "DeadMl.ml", line 1, characters 1-121
-  DeadMl.QQ is a dead module as all its items are dead.
-
   Warning Dead Value
   File "DeadMl.ml", line 3, characters 5-94
   QQ.thisSpansSeveralLines is never used
   <-- line 3
             x + y : int -> int -> int) [@@dead "QQ.thisSpansSeveralLines"] 
 
-  Warning Dead Module
-  File "DeadMl.ml", line 8, characters 1-104
-  DeadMl.AA is a dead module as all its items are dead.
-
   Warning Dead Value
   File "DeadMl.ml", line 9, characters 3-41
   AA.thisIsInInterface is never used
@@ -2774,10 +2758,6 @@ File References
   <-- line 17
   type thisIsDead = | DeadA [@dead "thisIsDead.DeadA"]  | DeadB [@dead "thisIsDead.DeadB"] 
 
-  Warning Dead Module
-  File "DeadMl.ml", line 25, characters 1-257
-  DeadMl.Bs_version is a dead module as all its items are dead.
-
   Warning Dead Value
   File "DeadMl.ml", line 26, characters 7-27
   Bs_version.version is never used
@@ -2916,10 +2896,6 @@ File References
   <-- line 2
   @dead("fortytwo") let fortytwo = 42
 
-  Warning Dead Module
-  File "DeadTest.res", line 27, characters 8-98
-  DeadTest.M is a dead module as all its items are dead.
-
   Warning Dead Value
   File "DeadTest.res", line 31, characters 3-35
   M.thisSignatureItemIsDead is never used
@@ -2974,10 +2950,6 @@ File References
   <-- line 96
   @dead("withDefaultValue") let withDefaultValue = (~paramWithDefault=3, y) => paramWithDefault + y
 
-  Warning Dead Module
-  File "DeadTest.res", line 110, characters 8-414
-  DeadTest.LazyDynamicallyLoadedComponent2 is a dead module as all its items are dead.
-
   Warning Dead Value
   File "DeadTest.res", line 114, characters 3-55
   LazyDynamicallyLoadedComponent2.makeProps is never used
@@ -3024,20 +2996,12 @@ File References
   <-- line 175
   type rc = {@dead("rc.a") a: int}
 
-  Warning Dead Module
-  File "DeadTestBlacklist.res", line 0, characters 1-1
-  DeadTestBlacklist is a dead module as all its items are dead.
-
   Warning Dead Value
   File "DeadTestBlacklist.res", line 1, characters 1-11
   x is never used
   <-- line 1
   @dead("x") let x = 34
 
-  Warning Dead Module
-  File "DeadTestWithInterface.res", line 1, characters 8-55
-  DeadTestWithInterface.Ext_buffer is a dead module as all its items are dead.
-
   Warning Dead Value
   File "DeadTestWithInterface.res", line 2, characters 3-13
   Ext_buffer.x is never used
@@ -3104,20 +3068,12 @@ File References
   <-- line 61
     | @dead("t.B") B
 
-  Warning Dead Module
-  File "ErrorHandler.resi", line 0, characters 1-1
-  ErrorHandler is a dead module as all its items are dead.
-
   Warning Dead Value
   File "ErrorHandler.resi", line 10, characters 1-11
   x is never used
   <-- line 10
   @dead("x") let x: int
 
-  Warning Dead Module
-  File "EverythingLiveHere.res", line 0, characters 1-1
-  EverythingLiveHere is a dead module as all its items are dead.
-
   Warning Dead Value
   File "EverythingLiveHere.res", line 1, characters 1-10
   x is never used
@@ -3136,10 +3092,6 @@ File References
   <-- line 5
   @dead("z") let z = 4
 
-  Warning Dead Module
-  File "FirstClassModulesInterface.res", line 0, characters 1-1
-  FirstClassModulesInterface is a dead module as all its items are dead.
-
   Warning Dead Type
   File "FirstClassModulesInterface.res", line 2, characters 3-9
   record.x is a record label never used to read a value
@@ -3152,10 +3104,6 @@ File References
   <-- line 3
     @dead("record.y") y: string,
 
-  Warning Dead Module
-  File "FirstClassModulesInterface.resi", line 0, characters 1-1
-  FirstClassModulesInterface is a dead module as all its items are dead.
-
   Warning Dead Type
   File "FirstClassModulesInterface.resi", line 3, characters 3-9
   record.x is a record label never used to read a value
@@ -3588,40 +3536,24 @@ File References
   <-- line 12
   @dead("make") let make = make
 
-  Warning Dead Module
-  File "JsxV4.res", line 3, characters 8-62
-  JsxV4.C is a dead module as all its items are dead.
-
   Warning Dead Value
   File "JsxV4.res", line 4, characters 20-47
   C.make is never used
   <-- line 4
     @react.component @dead("C.make") let make = () => React.null
 
-  Warning Dead Module
-  File "ModuleAliases.res", line 2, characters 10-57
-  ModuleAliases.Outer.Inner is a dead module as all its items are dead.
-
   Warning Dead Type
   File "ModuleAliases.res", line 3, characters 20-33
   Outer.Inner.innerT.inner is a record label never used to read a value
   <-- line 3
       type innerT = {@dead("Outer.Inner.innerT.inner") inner: string}
 
-  Warning Dead Module
-  File "ModuleAliases.res", line 10, characters 12-62
-  ModuleAliases.Outer2.Inner2.InnerNested is a dead module as all its items are dead.
-
   Warning Dead Type
   File "ModuleAliases.res", line 11, characters 17-28
   Outer2.Inner2.InnerNested.t.nested is a record label never used to read a value
   <-- line 11
         type t = {@dead("Outer2.Inner2.InnerNested.t.nested") nested: int}
 
-  Warning Dead Module
-  File "ModuleAliases2.res", line 0, characters 1-1
-  ModuleAliases2 is a dead module as all its items are dead.
-
   Warning Dead Type
   File "ModuleAliases2.res", line 3, characters 3-9
   record.x is a record label never used to read a value
@@ -3634,20 +3566,12 @@ File References
   <-- line 4
     @dead("record.y") y: string,
 
-  Warning Dead Module
-  File "ModuleAliases2.res", line 7, characters 8-131
-  ModuleAliases2.Outer is a dead module as all its items are dead.
-
   Warning Dead Type
   File "ModuleAliases2.res", line 9, characters 17-30
   Outer.outer.outer is a record label never used to read a value
   <-- line 9
     type outer = {@dead("Outer.outer.outer") outer: string}
 
-  Warning Dead Module
-  File "ModuleAliases2.res", line 11, characters 10-69
-  ModuleAliases2.Outer.Inner is a dead module as all its items are dead.
-
   Warning Dead Type
   File "ModuleAliases2.res", line 13, characters 19-32
   Outer.Inner.inner.inner is a record label never used to read a value
@@ -3660,10 +3584,6 @@ File References
   <-- line 21
   @dead("q") let q = 42
 
-  Warning Dead Module
-  File "ModuleExceptionBug.res", line 1, characters 8-53
-  ModuleExceptionBug.Dep is a dead module as all its items are dead.
-
   Warning Dead Value
   File "ModuleExceptionBug.res", line 2, characters 3-36
   Dep.customDouble is never used
@@ -3730,10 +3650,6 @@ File References
   <-- line 47
       | @dead("Universe.variant.B") B(string)
 
-  Warning Dead Module
-  File "Newsyntax.res", line 0, characters 1-1
-  Newsyntax is a dead module as all its items are dead.
-
   Warning Dead Value
   File "Newsyntax.res", line 1, characters 1-11
   x is never used
@@ -3914,10 +3830,6 @@ File References
   <-- line 11
   type toPayload = {@dead("toPayload.result") result: string}
 
-  Warning Dead Module
-  File "TransitiveType2.res", line 0, characters 1-1
-  TransitiveType2 is a dead module as all its items are dead.
-
   Warning Dead Value
   File "TransitiveType2.res", line 7, characters 1-29
   convertT2 is never used
@@ -3936,20 +3848,12 @@ File References
   <-- line 4
     @dead("t3.s") s: string,
 
-  Warning Dead Module
-  File "TypeParams1.res", line 0, characters 1-1
-  TypeParams1 is a dead module as all its items are dead.
-
   Warning Dead Value
   File "TypeParams1.res", line 4, characters 1-25
   exportSomething is never used
   <-- line 4
   @dead("exportSomething") let exportSomething = 10
 
-  Warning Dead Module
-  File "TypeParams2.res", line 0, characters 1-1
-  TypeParams2 is a dead module as all its items are dead.
-
   Warning Dead Type
   File "TypeParams2.res", line 2, characters 14-21
   item.id is a record label never used to read a value
@@ -4010,10 +3914,6 @@ File References
   <-- line 133
   type someRecord = {@dead("someRecord.id") id: int}
 
-  Warning Dead Module
-  File "Types.res", line 161, characters 8-80
-  Types.ObjectId is a dead module as all its items are dead.
-
   Warning Dead Value
   File "Types.res", line 166, characters 3-12
   ObjectId.x is never used
@@ -4122,4 +4022,4 @@ File References
   <-- line 96
   type variant1Object = | @dead("variant1Object.R") R(payload)
 
-  Analysis reported 269 issues (Incorrect Dead Annotation:1, Warning Dead Exception:2, Warning Dead Module:25, Warning Dead Type:89, Warning Dead Value:135, Warning Dead Value With Side Effects:1, Warning Redundant Optional Argument:5, Warning Unused Argument:11)
+  Analysis reported 244 issues (Incorrect Dead Annotation:1, Warning Dead Exception:2, Warning Dead Type:89, Warning Dead Value:135, Warning Dead Value With Side Effects:1, Warning Redundant Optional Argument:5, Warning Unused Argument:11)

analysis/reanalyze/src/DeadCommon.ml

@@ -406,9 +406,10 @@ let emitWarning ~decl ~message deadWarning =
       WriteDeadAnnotations.addLineAnnotation ~decl
     else None
   in
-  decl.path
-  |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
-  |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
+  if Config.reportTransitive then
+    decl.path
+    |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
+    |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
   Log_.warning ~loc
     (DeadWarning
        {
@@ -555,9 +556,10 @@ module Decl = struct
         && (Config.reportTransitive || not (hasRefBelow ()))
       in
       if shouldEmitWarning then (
-        decl.path
-        |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
-        |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
+        if Config.reportTransitive then
+          decl.path
+          |> Path.toModuleName ~isType:(decl.declKind |> DeclKind.isType)
+          |> DeadModules.checkModuleDead ~fileName:decl.pos.pos_fname;
         emitWarning ~decl ~message name)
 end
 

analysis/tests/src/expected/Dce.res.txt

@@ -1,3 +1,3 @@
 DCE src/Dce.res
-issues:2
+issues:0