add tests

Author: aspeddro

analysis/src/Commands.ml

@@ -261,7 +261,7 @@ let diagnosticSyntax ~path =
   print_endline
     (match Diagnostics.document_syntax ~path with
     | [] -> Protocol.null
-    | d -> "[\n" ^ String.concat ",\n" d ^ "\n]")
+    | d -> Protocol.array d)
 
 let test ~path =
   Uri.stripPath := true;
@@ -384,6 +384,7 @@ let test ~path =
                                  Printf.printf "%s\nnewText:\n%s<--here\n%s%s\n"
                                    (Protocol.stringifyRange range)
                                    indent indent newText)))
+          | "dia" -> diagnosticSyntax ~path
           | _ -> ());
           print_newline ())
     in

analysis/src/Diagnostics.ml

@@ -7,7 +7,7 @@ let document_syntax ~path =
   | [] -> []
   | diagnostics ->
     diagnostics
-    |> List.map (fun diagnostic ->
+    |> List.rev_map (fun diagnostic ->
            let _, startline, startcol =
              Location.get_pos_info (Res_diagnostics.getStartPos diagnostic)
            in
@@ -23,5 +23,4 @@ let document_syntax ~path =
                  };
                message = Res_diagnostics.explain diagnostic;
                severity = Error;
-             })
-    |> List.rev
+             })

analysis/tests/bsconfig.json

@@ -9,6 +9,7 @@
       "subdirs": true
     }
   ],
+  "ignored-dirs": ["src/not_compiled"],
   "bsc-flags": ["-w -33-44"],
   "bs-dependencies": ["@rescript/react"],
   "reason": { "react-jsx": 3 }

analysis/tests/src/Diagnostics.res renamed to analysis/tests/src/not_compiled/Diagnostics.res

@@ -1,3 +1,5 @@
 let = 1 + 1.0
 let add = =2
-lett a = 2
+lett a = 2
+
+//^dia

analysis/tests/src/not_compiled/expected/Diagnostics.res.txt

@@ -0,0 +1,13 @@
+[{
+  "range: {"start": {"line": 1, "character": 4}, "end": {"line": 1, "character": 5}},
+  "message": "I was expecting a name for this let-binding. Example: `let message = \"hello\"`",
+  "severity": 1,
+}, {
+  "range: {"start": {"line": 2, "character": 9}, "end": {"line": 2, "character": 11}},
+  "message": "This let-binding misses an expression",
+  "severity": 1,
+}, {
+  "range: {"start": {"line": 3, "character": 4}, "end": {"line": 3, "character": 6}},
+  "message": "consecutive statements on a line must be separated by ';' or a newline",
+  "severity": 1,
+}]

analysis/tests/test.sh

@@ -7,6 +7,15 @@ for file in src/*.{res,resi}; do
   fi
 done
 
+for file in src/not_compiled/*.res; do
+  output="$(dirname $file)/expected/$(basename $file).txt"
+  ../rescript-editor-analysis.exe test $file &> $output
+  # CI. We use LF, and the CI OCaml fork prints CRLF. Convert.
+  if [ "$RUNNER_OS" == "Windows" ]; then
+    perl -pi -e 's/\r\n/\n/g' -- $output
+  fi
+done
+
 warningYellow='\033[0;33m'
 successGreen='\033[0;32m'
 reset='\033[0m'