Skip to content

Commit 64898b5

Browse files
committed
make sure payloads (with any as placeholder) are printed for each constructor argument
1 parent 78e468b commit 64898b5

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

analysis/src/CompletionBackEnd.ml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1539,7 +1539,17 @@ let rec completeTypedValue t ~env ~full ~prefix ~expandOption =
15391539
then None
15401540
else
15411541
Some
1542-
(Completion.create ~name:constructor.cname.txt
1542+
(Completion.create
1543+
~name:
1544+
(constructor.cname.txt
1545+
^
1546+
if constructor.args |> List.length > 0 then
1547+
"("
1548+
^ (constructor.args
1549+
|> List.map (fun _ -> "_")
1550+
|> String.concat ", ")
1551+
^ ")"
1552+
else "")
15431553
~kind:(Constructor (constructor, "" (* TODO *)))
15441554
~env))
15451555
in

analysis/tests/src/CompletionFunctionArguments.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ let someOtherFn = (includeName, age) => {
3030
// let _ = someOtherFn(f)
3131
// ^com
3232

33-
type someVariant = One | Two | Three(int)
33+
type someVariant = One | Two | Three(int, string)
3434

3535
let someFnTakingVariant = (
3636
configOpt: option<someVariant>,

analysis/tests/src/expected/CompletionFunctionArguments.res.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,10 @@ Completable: Value[someFnTakingVariant](~config)
9797
"detail": "Two\n\n",
9898
"documentation": null
9999
}, {
100-
"label": "Three",
100+
"label": "Three(_, _)",
101101
"kind": 4,
102102
"tags": [],
103-
"detail": "Three(int)\n\n",
103+
"detail": "Three(int, string)\n\n",
104104
"documentation": null
105105
}]
106106

0 commit comments

Comments
 (0)