simple completion for tuples

Author: zth

analysis/src/CompletionBackEnd.ml

@@ -1518,7 +1518,7 @@ let rec extractType ~env ~package (t : Types.type_expr) =
         (Tvariant
            {env; constructors; variantName = name.txt; variantDecl = decl})
     | _ -> None)
-  | Ttuple expressions -> Some (Tuple (env, expressions))
+  | Ttuple expressions -> Some (Tuple (env, expressions, t))
   | _ -> None
 
 let filterItems items ~prefix =
@@ -1585,6 +1585,14 @@ let completeTypedValue ~env ~envWhereCompletionStarted ~full ~prefix
             ~env ~insertText:"Some(${1:_})" ();
         ]
         |> filterItems ~prefix
+      | Some (Tuple (env, exprs, typ)) ->
+        let numExprs = List.length exprs in
+        [
+          Completion.createWithSnippet
+            ~name:(printConstructorArgs numExprs ~asSnippet:false)
+            ~insertText:(printConstructorArgs numExprs ~asSnippet:true)
+            ~kind:(Value typ) ~env ();
+        ]
       | _ -> []
     in
     (* Include all values and modules in completion if there's a prefix, not otherwise *)

analysis/src/SharedTypes.ml

@@ -569,7 +569,7 @@ module Completable = struct
 
   (** An extracted type from a type expr *)
   type extractedType =
-    | Tuple of QueryEnv.t * Types.type_expr list
+    | Tuple of QueryEnv.t * Types.type_expr list * Types.type_expr
     | Toption of QueryEnv.t * Types.type_expr
     | Tbool of QueryEnv.t
     | Tvariant of {

analysis/tests/src/CompletionFunctionArguments.res

@@ -69,3 +69,10 @@ let someFnTakingVariant = (
 
 // let _ = 1->someOtherFn(1, t)
 //                            ^com
+
+let fnTakingTuple = (arg: (int, int, float)) => {
+  ignore(arg)
+}
+
+// let _ = fnTakingTuple()
+//                       ^com

analysis/tests/src/expected/CompletionFunctionArguments.res.txt

@@ -84,6 +84,12 @@ Completable: Cargument Value[someOtherFn]($0=f)
     "tags": [],
     "detail": "bool",
     "documentation": null
+  }, {
+    "label": "fnTakingTuple",
+    "kind": 12,
+    "tags": [],
+    "detail": "((int, int, float)) => unit",
+    "documentation": null
   }]
 
 Complete src/CompletionFunctionArguments.res 51:39
@@ -223,3 +229,17 @@ Completable: Cargument Value[someOtherFn]($2=t)
     "documentation": null
   }]
 
+Complete src/CompletionFunctionArguments.res 76:25
+posCursor:[76:25] posNoWhite:[76:24] Found expr:[76:11->76:26]
+Pexp_apply ...[76:11->76:24] (...[76:25->76:26])
+Completable: Cargument Value[fnTakingTuple]($0)
+[{
+    "label": "(_, _, _)",
+    "kind": 12,
+    "tags": [],
+    "detail": "(int, int, float)",
+    "documentation": null,
+    "insertText": "(${1:_}, ${2:_}, ${3:_})",
+    "insertTextFormat": 2
+  }]
+