Skip to content

Commit 5ed5b8a

Browse files
committed
Comment on what heuristics are not currently testable.
1 parent bdc5a07 commit 5ed5b8a

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

analysis/src/References.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ let getLocItem ~full ~pos ~debug =
6666
]
6767
(* For older compiler 9.0 or earlier *)
6868
when li1.loc = li2.loc && li2.loc = li3.loc ->
69+
(* Not currently testable *)
6970
log 6
7071
"heuristic for JSX and compiler combined:\n\
7172
~x becomes Js_OO.unsafe_downgrade(Props)#x\n\
@@ -83,6 +84,7 @@ let getLocItem ~full ~pos ~debug =
8384
heuristic for: [Props, arg], give loc of `arg`";
8485
Some li2
8586
| [li1; li2; li3] when li1.loc = li2.loc && li2.loc = li3.loc ->
87+
(* Not currently testable *)
8688
log 8
8789
"heuristic for JSX with at most one child\n\
8890
heuristic for: [makeProps, make, createElement], give the loc of `make` ";

analysis/tests/package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

analysis/tests/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
"build": "rescript",
44
"clean": "rescript clean -with-deps"
55
},
6-
"dependencies": {
7-
"rescript": "9.1.2"
8-
},
96
"private": true,
107
"devDependencies": {
118
"@rescript/react": "^0.10.3"
9+
},
10+
"dependencies": {
11+
"rescript": "^9.1.4"
1212
}
1313
}

0 commit comments

Comments
 (0)