Add tests to verify that jump-to-definition still works with previous ocaml versions (#369)

Author: jaredly

.ci/build-platform.yml

@@ -17,17 +17,14 @@ jobs:
       - template: utils/use-node.yml
       - template: utils/use-esy.yml
       - template: utils/restore-build-cache.yml
-      - script: "esy install"
-        displayName: "esy install"
-      - script: "esy build"
-        displayName: "esy build"
-      # - script: "esy test"
-      #   displayName: "Test command"
+      - script: "esy"
+        displayName: "esy install & build"
+      - bash: ./runtests.sh
+        displayName: "Run some tests"
       - template: utils/publish-build-cache.yml
-      - bash: ./_build/default/src/analyze_example_tests/ExamplesTests.exe
-      - bash: ./_build/default/util_tests/UtilTests.exe
       - bash: mkdir -p rls-release
-      - bash: cp _build/default/bin/Bin.exe rls-release/reason-language-server.exe
+      - bash: esy cp-bin
+      - bash: cp bin.exe rls-release/reason-language-server.exe
       - task: PublishBuildArtifacts@1
         displayName: 'Upload binary'
         inputs:

.github/workflows/main.yml

@@ -1,4 +1,10 @@
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
 
 jobs:
   build:
@@ -20,14 +26,8 @@ jobs:
     - name: install esy
       run: |
         npm install -g esy
-    - name: Install dependencies
-      run: |
-        esy install
-    - name: Building reason-langage-server
-      run: |
-        esy build
-      env:
-        CI: true
-    - name: Building all in reason-langage-server
-      run: |
-        esy build dune build @all
+    - name: Esy
+      run: esy
+    - name: Running some tests
+      run: ./runtests.sh
+      shell: bash

.gitignore

@@ -25,3 +25,4 @@ bsb_modules
 _esy/
 bin.exe
 ExamplesTests.exe
+AllTests.exe

core/References.re

@@ -1,7 +1,7 @@
 
 open SharedTypes;
 
-let debugReferences = ref(false);
+let debugReferences = ref(true);
 
 let maybeLog = m => {
   if (debugReferences^) {

editor-extensions/vscode/package.json

@@ -39,6 +39,10 @@
 			{
 				"command": "reason-language-server.create_interface",
 				"title": "Reason: Create an interface file for this implementation file."
+			},
+			{
+				"command": "reason-language-server.dump_file_data",
+				"title": "Reason: dump data on the current file"
 			}
 		],
 		"snippets": [

editor-extensions/vscode/src/index.js

@@ -274,6 +274,24 @@ function activate(context) {
 
     vscode.commands.registerCommand('reason-language-server.show_ppxed_source', showPpxedSource);
 
+    vscode.commands.registerCommand('reason-language-server.dump_file_data', () => {
+        if (!client) {
+            return vscode.window.showInformationMessage('Language server not running');
+        }
+        const editor = vscode.window.activeTextEditor;
+        if (!editor) {
+            return vscode.window.showInformationMessage('No active editor');
+        }
+        if (editor.document.languageId !== 'ocaml' && editor.document.languageId !== 'reason') {
+            return vscode.window.showInformationMessage('Not an OCaml or Reason file');
+        }
+        client.sendRequest("custom:reasonLanguageServer/dumpFileData", {
+            "textDocument": {
+                "uri": editor.document.uri.with({scheme: 'file'}).toString(),
+            },
+        })
+    });
+
     const showAst = () => {
         if (!client) {
             return vscode.window.showInformationMessage('Language server not running');

examples/example-esy-dune-project/bin/Hello.re

@@ -11,6 +11,9 @@ let l = More.outer + More.n + Other.inner;
 
 let n = More.n;
 
+let x = 10;
+let y = x;
+
 More.party;
 string_of_bool;
 

old_ocamls/407/dune-project

@@ -0,0 +1 @@
+(lang dune 1.6)

old_ocamls/407/esy.json

@@ -0,0 +1,6 @@
+{
+  "devDependencies": {
+    "ocaml": "~4.7",
+    "@esy-ocaml/reason": "*"
+  }
+}

old_ocamls/407/esy.lock/.gitattributes

@@ -0,0 +1,3 @@
+
+# Set eol to LF so files aren't converted to CRLF-eol on Windows.
+* text eol=lf

old_ocamls/407/esy.lock/.gitignore

@@ -0,0 +1,3 @@
+
+# Reset any possible .gitignore, we want all esy.lock to be un-ignored.
+!*