Hover: expand definition of type arguments.

Author: cristianoc

analysis/src/Shared.ml

@@ -49,7 +49,9 @@ let findTypeConstructors (tel : Types.type_expr list) =
   let rec loop (te : Types.type_expr) =
     match te.desc with
     | Tlink te1 | Tsubst te1 | Tpoly (te1, _) -> loop te1
-    | Tconstr (path, _, _) -> addPath path
+    | Tconstr (path, args, _) ->
+      addPath path;
+      args |> List.iter loop
     | Tarrow (_, te1, te2, _) ->
       loop te1;
       loop te2

analysis/tests/src/Hover.res

@@ -190,10 +190,15 @@ module TypeSubstitutionRecords = {
 module CompV4 = {
   type props<'n, 's> = {n?: 'n, s: 's}
   let make = props => {
-    let _ = props.n == Some (10)
+    let _ = props.n == Some(10)
     React.string(props.s)
   }
 }
 
 let mk = CompV4.make
 //  ^hov
+
+type useR = {x: int, y: list<option<r<float>>>}
+
+let testUseR = (v: useR) => v
+//              ^hov

analysis/tests/src/expected/Div.res.txt

@@ -1,6 +1,6 @@
 Hover src/Div.res 0:10
 getLocItem #3: heuristic for <div>
-{"contents": "```rescript\n(\n  string,\n  ~props: ReactDOMRe.domProps=?,\n  array<React.element>,\n) => React.element\n```\n\n```rescript\ntype element\n```"}
+{"contents": "```rescript\n(\n  string,\n  ~props: ReactDOMRe.domProps=?,\n  array<React.element>,\n) => React.element\n```\n\n```rescript\ntype domProps = ReactDOM.Props.domProps\n```\n\n```rescript\ntype element\n```"}
 
 Complete src/Div.res 3:17
 posCursor:[3:17] posNoWhite:[3:16] Found expr:[3:4->3:17]

analysis/tests/src/expected/Hover.res.txt

@@ -105,7 +105,7 @@ Hover src/Hover.res 148:6
 {"contents": "```rescript\nint\n```\n\n doc comment 2 "}
 
 Hover src/Hover.res 165:23
-{"contents": "```rescript\nfoo<bar>\n```\n\n```rescript\ntype foo<'a> = {content: 'a, zzz: string}\n```"}
+{"contents": "```rescript\nfoo<bar>\n```\n\n```rescript\ntype foo<'a> = {content: 'a, zzz: string}\n```\n\n```rescript\ntype bar = {age: int}\n```"}
 
 Hover src/Hover.res 167:22
 {"contents": "```rescript\nfoobar\n```\n\n```rescript\ntype foobar = foo<bar>\n```"}
@@ -161,3 +161,6 @@ Completable: Cpath Value[y2].content.""
 Hover src/Hover.res 197:4
 {"contents": "```rescript\nCompV4.props<int, string> => React.element\n```\n\n```rescript\ntype props<'n, 's> = {?n: 'n, s: 's}\n```\n\n```rescript\ntype element\n```"}
 
+Hover src/Hover.res 202:16
+{"contents": "```rescript\nuseR\n```\n\n```rescript\ntype useR = {x: int, y: list<option<r<float>>>}\n```\n\n```rescript\ntype r<'a> = {i: 'a, f: float}\n```"}
+