Follow through type definitions during object completion.

The type of a nested object can be spread across several type definitions sometimes across several files.
When completing `foo["x"]["y"]["z`, look up the type definitions to expand them when traversing the type.

Author: cristianoc

analysis/src/NewCompletions.ml

@@ -1159,10 +1159,17 @@ let processCompletable ~findItems ~full ~package ~rawOpens
       | Tvar None -> []
       | _ -> []
     in
+    let envRef = ref (QueryEnv.fromFile full.file) in
     let rec getObj (t : Types.type_expr) =
       match t.desc with
       | Tlink t1 | Tsubst t1 | Tpoly (t1, []) -> getObj t1
       | Tobject (tObj, _) -> getFields tObj
+      | Tconstr (path, _, _) -> (
+        match Hover.digConstructor ~env:envRef.contents ~package path with
+        | Some (env, {item = {decl = {type_manifest = Some tt}}}) ->
+          envRef := env;
+          getObj tt
+        | _ -> [])
       | _ -> []
     in
     let fields =

analysis/tests/src/Completion.res

@@ -76,3 +76,10 @@ let someObj = {"name": "a", "age": 32}
 let nestedObj = {"x": {"y": {"name": "a", "age": 32}}}
 
 //^com nestedObj["x"]["y"]["
+
+let o : Obj.objT = assert false
+//^com o["a
+
+type nestedObjT = {"x": Obj.nestedObjT}
+let no : nestedObjT = assert false
+//^com no["x"]["y"]["

analysis/tests/src/Obj.res

@@ -0,0 +1,3 @@
+type objT = {"name": string, "age": int}
+
+type nestedObjT = {"y": objT}

analysis/tests/src/expected/Completion.res.txt

@@ -539,6 +539,21 @@ DocumentSymbol tests/src/Completion.res
         "name": "nestedObj",
         "kind": 19,
         "location": {"uri": "Completion.res", "range": {"start": {"line": 75, "character": 4}, "end": {"line": 75, "character": 13}}}
+},
+{
+        "name": "o",
+        "kind": 13,
+        "location": {"uri": "Completion.res", "range": {"start": {"line": 79, "character": 4}, "end": {"line": 79, "character": 5}}}
+},
+{
+        "name": "nestedObjT",
+        "kind": 26,
+        "location": {"uri": "Completion.res", "range": {"start": {"line": 82, "character": 0}, "end": {"line": 82, "character": 39}}}
+},
+{
+        "name": "no",
+        "kind": 13,
+        "location": {"uri": "Completion.res", "range": {"start": {"line": 83, "character": 4}, "end": {"line": 83, "character": 6}}}
 }
 ]
 
@@ -626,3 +641,27 @@ Complete tests/src/Completion.res 76:2
     "documentation": null
   }]
 
+Complete tests/src/Completion.res 79:2
+[{
+    "label": "age",
+    "kind": 4,
+    "tags": [],
+    "detail": "int",
+    "documentation": null
+  }]
+
+Complete tests/src/Completion.res 83:2
+[{
+    "label": "name",
+    "kind": 4,
+    "tags": [],
+    "detail": "string",
+    "documentation": null
+  }, {
+    "label": "age",
+    "kind": 4,
+    "tags": [],
+    "detail": "int",
+    "documentation": null
+  }]
+

analysis/tests/src/expected/Debug.res.txt

@@ -3,7 +3,7 @@ Dependencies: @rescript/react
 Source directories: tests/node_modules/@rescript/react/./src tests/node_modules/@rescript/react/./src/legacy
 Source files: tests/node_modules/@rescript/react/./src/React.res tests/node_modules/@rescript/react/./src/ReactDOM.res tests/node_modules/@rescript/react/./src/ReactDOMServer.res tests/node_modules/@rescript/react/./src/ReactDOMStyle.res tests/node_modules/@rescript/react/./src/ReactEvent.res tests/node_modules/@rescript/react/./src/ReactEvent.resi tests/node_modules/@rescript/react/./src/ReactTestUtils.res tests/node_modules/@rescript/react/./src/ReactTestUtils.resi tests/node_modules/@rescript/react/./src/RescriptReactErrorBoundary.res tests/node_modules/@rescript/react/./src/RescriptReactErrorBoundary.resi tests/node_modules/@rescript/react/./src/RescriptReactRouter.res tests/node_modules/@rescript/react/./src/RescriptReactRouter.resi tests/node_modules/@rescript/react/./src/legacy/ReactDOMRe.res tests/node_modules/@rescript/react/./src/legacy/ReasonReact.res
 Source directories: tests/src
-Source files: tests/src/Auto.res tests/src/Completion.res tests/src/Component.res tests/src/Component.resi tests/src/Cross.res tests/src/Debug.res tests/src/Definition.res tests/src/DefinitionWithInterface.res tests/src/DefinitionWithInterface.resi tests/src/Div.res tests/src/Fragment.res tests/src/Hover.res tests/src/Jsx.res tests/src/Jsx.resi tests/src/Patterns.res tests/src/RecModules.res tests/src/RecordCompletion.res tests/src/References.res tests/src/ReferencesWithInterface.res tests/src/ReferencesWithInterface.resi tests/src/Rename.res tests/src/RenameWithInterface.res tests/src/RenameWithInterface.resi tests/src/TypeDefinition.res
+Source files: tests/src/Auto.res tests/src/Completion.res tests/src/Component.res tests/src/Component.resi tests/src/Cross.res tests/src/Debug.res tests/src/Definition.res tests/src/DefinitionWithInterface.res tests/src/DefinitionWithInterface.resi tests/src/Div.res tests/src/Fragment.res tests/src/Hover.res tests/src/Jsx.res tests/src/Jsx.resi tests/src/Obj.res tests/src/Patterns.res tests/src/RecModules.res tests/src/RecordCompletion.res tests/src/References.res tests/src/ReferencesWithInterface.res tests/src/ReferencesWithInterface.resi tests/src/Rename.res tests/src/RenameWithInterface.res tests/src/RenameWithInterface.resi tests/src/TypeDefinition.res
 Impl cmt:tests/lib/bs/./src/Auto.cmt res:tests/src/Auto.res
 Impl cmt:tests/lib/bs/./src/Completion.cmt res:tests/src/Completion.res
 IntfAndImpl cmti:tests/lib/bs/./src/Component.cmti resi:tests/src/Component.resi cmt:tests/lib/bs/./src/Component.cmt res:tests/src/Component.res
@@ -15,6 +15,7 @@ Impl cmt:tests/lib/bs/./src/Div.cmt res:tests/src/Div.res
 Impl cmt:tests/lib/bs/./src/Fragment.cmt res:tests/src/Fragment.res
 Impl cmt:tests/lib/bs/./src/Hover.cmt res:tests/src/Hover.res
 IntfAndImpl cmti:tests/lib/bs/./src/Jsx.cmti resi:tests/src/Jsx.resi cmt:tests/lib/bs/./src/Jsx.cmt res:tests/src/Jsx.res
+Impl cmt:tests/lib/bs/./src/Obj.cmt res:tests/src/Obj.res
 Impl cmt:tests/lib/bs/./src/Patterns.cmt res:tests/src/Patterns.res
 Impl cmt:tests/lib/bs/./src/RecModules.cmt res:tests/src/RecModules.res
 Impl cmt:tests/lib/bs/./src/RecordCompletion.cmt res:tests/src/RecordCompletion.res