Skip to content

Commit 12a1c4b

Browse files
authored
Reactivate CI make test for windows (#186)
Previously the windows CI hanging was an actual analysis binary issue. Now it doesn't repro after we started using the `rescript` package instead of `bs-platform`. So we wrongly blamed the CI. We'll investigate this bug next.
1 parent 5f7fc56 commit 12a1c4b

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,11 @@ jobs:
2222
build: eval $(opam env) && cd analysis && make test
2323
artifact-folder: linux
2424
- os: windows-latest
25-
# CI windows running the binary somehow stucks. Not sure why. Disable for now.
26-
build: "cd analysis && & $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make"
25+
build: |
26+
cd analysis
27+
# git checkout converted these to windows newline. Convert back to unix newline here
28+
dos2unix test.sh tests/src/*.res tests/src/*.resi
29+
& $env:CYGWIN_ROOT\\bin\\ocaml-env exec -- make
2730
artifact-folder: win32
2831

2932
runs-on: ${{matrix.os}}

0 commit comments

Comments
 (0)