cleanup

Author: zth

analysis/src/CompletionBackEnd.ml

@@ -1499,11 +1499,8 @@ let rec extractType ~env ~package (t : Types.type_expr) =
   match t.desc with
   | Tlink t1 | Tsubst t1 | Tpoly (t1, []) -> extractType ~env ~package t1
   | Tconstr (Path.Pident {name = "option"}, [payloadTypeExpr], _) ->
-    (* Handle option. TODO: Look up how the compiler does this and copy that behavior. *)
     Some (Toption (env, payloadTypeExpr))
-  | Tconstr (Path.Pident {name = "bool"}, [], _) ->
-    (* Handle bool. TODO: Look up how the compiler does this and copy that behavior. *)
-    Some (Tbool env)
+  | Tconstr (Path.Pident {name = "bool"}, [], _) -> Some (Tbool env)
   | Tconstr (path, _, _) -> (
     match References.digConstructor ~env ~package path with
     | Some (env, {item = {decl = {type_manifest = Some t1}}}) ->

analysis/src/CompletionFrontEnd.ml

@@ -149,8 +149,6 @@ let findArgCompletables ~(args : arg list) ~endPos ~posBeforeCursor
              {contextPath; argumentLabel = Labelled labelled.name; prefix = ""})
       else loop rest
     | {label = None; exp} :: rest ->
-      (* TODO: Better guard for this... This is so completion does not trigger
-         inside of template string calls, which are regular calls *)
       if Res_parsetree_viewer.isTemplateLiteral exp then None
       else if exp.pexp_loc |> Loc.hasPos ~pos:posBeforeCursor then
         (* Completing in an unlabelled argument *)

analysis/src/SharedTypes.ml

@@ -498,12 +498,6 @@ let locItemToString {loc = {Location.loc_start; loc_end}; locType} =
 (* needed for debugging *)
 let _ = locItemToString
 
-type polyVariantConstructor = {
-  name: string;
-  payload: Types.type_expr option;
-  args: Types.type_expr list;
-}
-
 module Completable = struct
   (* Completion context *)
   type completionContext = Type | Value | Module | Field