Skip to content

Commit 49c4a9b

Browse files
authored
Deprecated more props types (#65)
* Deprecated more props types * Address PR feedback
1 parent db826bd commit 49c4a9b

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## 0.11.0-alpha.2
44

55
- Relax React version requirement to v18.0.0+.
6-
- Deprecated type `ReactDOM.props`
6+
- Deprecated types `ReactDOM.props`, `ReactDOM.Props.props`, `ReactDOM.Props.domProps`.
77

88
**Breaking:**
99

src/ReactDOM.res

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,18 @@ module Ref = {
5656
external callbackDomRef: callbackDomRef => domRef = "%identity"
5757
}
5858

59+
type domProps = JsxDOM.domProps
60+
61+
@deprecated("Please use type ReactDOM.domProps")
62+
type props = JsxDOM.domProps
63+
5964
module Props = {
65+
@deprecated("Please use type ReactDOM.domProps")
6066
type domProps = JsxDOM.domProps
6167

6268
/** DEPRECATED */
6369
@deriving(abstract)
64-
@deprecated("Please use type domProps")
70+
@deprecated("Please use type ReactDOM.domProps")
6571
type props = {
6672
@optional
6773
key: string,
@@ -1084,10 +1090,8 @@ module Props = {
10841090
}
10851091
}
10861092

1087-
include Props
1088-
10891093
@variadic @module("react")
1090-
external createElement: (string, ~props: props=?, array<React.element>) => React.element =
1094+
external createElement: (string, ~props: domProps=?, array<React.element>) => React.element =
10911095
"createElement"
10921096

10931097
@variadic @module("react")

src/legacy/ReactDOMRe.res

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,17 @@
22
This module is kept for ReScript react-jsx v3 compatibility
33
We removed all functionality that is not needed for JSX usage
44
**/
5-
6-
include ReactDOM.Props
7-
8-
@variadic @module("react")
5+
@variadic
6+
@module("react")
97
external createDOMElementVariadic: (
108
string,
11-
~props: domProps=?,
9+
~props: ReactDOM_V3.domProps=?,
1210
array<React.element>,
1311
) => React.element = "createElement"
1412

1513
@variadic @module("react")
16-
external createElement: (string, ~props: props=?, array<React.element>) => React.element =
17-
"createElement"
14+
external createElement: (
15+
string,
16+
~props: ReactDOM_V3.domProps=?,
17+
array<React.element>,
18+
) => React.element = "createElement"

0 commit comments

Comments
 (0)