Don't wipe playground url on load; update on copy to clipboard #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiping the playground url turned out to be a less desirable UX than we thought. Sometime tabs get backgrounded then ejected, so reloading those with the default url gives us to the default snippet instead of the one we loaded. Same for when we undo a closed tab. I've removed that url wipe logic. I've also added the logic to update the url on copy to clipboard, because why not. Maybe an incomplete UX, but this beats updating the url every other second while typing, which would be jarring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiping the playground url turned out to be a less desirable UX than we
thought. Sometime tabs get backgrounded then ejected, so reloading those
with the default url gives us to the default snippet instead of the one
we loaded. Same for when we undo a closed tab.
I've removed that url wipe logic. I've also added the logic to update
the url on copy to clipboard, because why not. Maybe an incomplete UX,
but this beats updating the url every other second while typing, which
would be jarring