Remove settings for codelenses.

Author: cristianoc

.vscode/settings.json

@@ -9,7 +9,6 @@
   // "reason_language_server.location": "./lib/bs/native/bin.native",
   "reason_language_server.location": "./bin.exe",
   // "reason_language_server.show_debug_errors": true,
-  "reason_language_server.format_width": 100,
   // "reason_language_server.location": "./lib/bs/native/bin.native.exe",
   // "reason_language_server.reloadOnChange": true,
   "editor.tabSize": 2,

editor-extensions/coc.nvim/package.json

@@ -50,31 +50,6 @@
           },
           "description": "Only specify this if build system autodetection isn't working for you (for example if you have a bsconfig.json, and a dune file in the same project). The keys in this object should be in uri format, e.g. file:///some/path/here"
         },
-        "reason_language_server.format_width": {
-          "type": "number",
-          "default": 80,
-          "description": "Format width (default=80)"
-        },
-        "reason_language_server.per_value_codelens": {
-          "type": "boolean",
-          "default": false,
-          "description": "Show the type for each top-level value in a codelens"
-        },
-        "reason_language_server.dependencies_codelens": {
-          "type": "boolean",
-          "default": true,
-          "description": "Show the dependencies for a file at the top"
-        },
-        "reason_language_server.opens_codelens": {
-          "type": "boolean",
-          "default": true,
-          "description": "Indicate what values have been used from an open"
-        },
-        "reason_language_server.show_module_path_on_hover": {
-          "type": "boolean",
-          "default": true,
-          "description": "Show the module path on hover"
-        },
         "reason_language_server.reloadOnChange": {
           "type": "boolean",
           "default": false,

editor-extensions/vscode/Readme.md

@@ -27,11 +27,6 @@ Based on `vscode-reasonml`, but with a language server backend that's written en
 ## Configuration
 all configuration is prefixed with `reason_language_server.`
 
-- `.format_width` - defaults to 80
-- `.per_value_codelens` - show the type of each toplevel value in a lens
-- `.dependencies_codelens` - list a files dependencies at the top
-- `.opens_codelens` - show what values are used from an `open`
-
 ## Debugging configuration
 most useful if your developing the language server
 

editor-extensions/vscode/package.json

@@ -62,31 +62,6 @@
 					"type": "string",
 					"description": "Provide a location for an .ml/.mli formatter"
 				},
-				"reason_language_server.format_width": {
-					"type": "number",
-					"default": 80,
-					"description": "Format width (default=80)"
-				},
-				"reason_language_server.per_value_codelens": {
-					"type": "boolean",
-					"default": false,
-					"description": "Show the type for each top-level value in a codelens"
-				},
-				"reason_language_server.dependencies_codelens": {
-					"type": "boolean",
-					"default": true,
-					"description": "Show the dependencies for a file at the top"
-				},
-				"reason_language_server.opens_codelens": {
-					"type": "boolean",
-					"default": true,
-					"description": "Indicate what values have been used from an open"
-				},
-				"reason_language_server.show_module_path_on_hover": {
-					"type": "boolean",
-					"default": true,
-					"description": "Show the module path on hover"
-				},
 				"reason_language_server.reloadOnChange": {
 					"type": "boolean",
 					"default": false,

examples/example-project/.vscode/settings.json

@@ -2,7 +2,5 @@
   "editor.codeLens": true,
   "reason_language_server.location": "../../_build/install/default/bin/rescript-editor-support.exe",
   "reason_language_server.reloadOnChange": true,
-  "reason_language_server.per_value_codelens": true,
   "reason_language_server.show_debug_errors": true,
-  //"reason_language_server.show_module_path_on_hover": false
 }

examples/example-project/src/B.re

@@ -0,0 +1,9 @@
+
+
+let x = 12
+
+
+let y = 44
+
+
+let z = 123

src/rescript-editor-support/MessageHandlers.re

@@ -233,26 +233,14 @@ let handlers:
             List.append(currentCl, getTypeLensTopLevel(tlp));
           };
         };
-        let showToplevelTypes = state.settings.perValueCodelens; /* TODO config option */
-        let lenses =
-          showToplevelTypes
-            ? file.contents.topLevel |> getTypeLensTopLevel : [];
-        let showOpens = state.settings.opensCodelens;
-        let lenses =
-          showOpens
-            ? lenses
-              @ {
-                CodeLens.forOpens(extra);
-              }
-            : lenses;
+        let lenses = file.contents.topLevel |> getTypeLensTopLevel;
+        let lenses = lenses @ CodeLens.forOpens(extra);
 
         let depsList =
           List.map(fst, SharedTypes.hashList(extra.externalReferences));
         let depsString =
           depsList == [] ? "[none]" : String.concat(", ", depsList);
-        let lenses =
-          state.settings.dependenciesCodelens == true
-            ? [("Dependencies: " ++ depsString, topLoc), ...lenses] : lenses;
+        let lenses = [("Dependencies: " ++ depsString, topLoc), ...lenses];
 
         lenses;
       };

src/rescript-editor-support/NotificationHandlers.re

@@ -64,25 +64,8 @@ let notificationHandlers:
   ),
   (
     "workspace/didChangeConfiguration",
-    (state, params) => {
-      let settings =
-        params |> Json.get("settings") |?> Json.get("reason_language_server");
-      let perValueCodelens =
-        settings |?> Json.get("per_value_codelens") |?> Json.bool |? false;
-      let opensCodelens =
-        settings |?> Json.get("opens_codelens") |?> Json.bool |? true;
-      let dependenciesCodelens =
-        settings |?> Json.get("dependencies_codelens") |?> Json.bool |? true;
-
-      Ok({
-        ...state,
-        settings: {
-          ...state.settings,
-          perValueCodelens,
-          opensCodelens,
-          dependenciesCodelens,
-        },
-      });
+    (state, _params) => {
+      Ok(state);
     },
   ),
   (

src/rescript-editor-support/TopTypes.re

@@ -16,12 +16,7 @@ type package = {
   opens: list(string),
 };
 
-type settings = {
-  perValueCodelens: bool,
-  opensCodelens: bool,
-  dependenciesCodelens: bool,
-  recordAllLocations: bool,
-};
+type settings = {recordAllLocations: bool};
 
 type state = {
   rootUri: uri,
@@ -39,9 +34,6 @@ let empty = () => {
   rootForUri: Hashtbl.create(30),
   cmtCache: Hashtbl.create(30),
   settings: {
-    perValueCodelens: false,
-    opensCodelens: true,
-    dependenciesCodelens: true,
     recordAllLocations: false,
   },
 };