From 24a7838f80c4c209537202c0e6a58ebaacc6eda1 Mon Sep 17 00:00:00 2001 From: Gabriel Nordeborn Date: Sun, 5 Mar 2023 09:39:05 +0100 Subject: [PATCH 1/2] switch global null to come from Nullable module and not Null --- src/RescriptCore.res | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/RescriptCore.res b/src/RescriptCore.res index d76bcde0..74fdad58 100644 --- a/src/RescriptCore.res +++ b/src/RescriptCore.res @@ -47,7 +47,7 @@ module Intl = Core__Intl @val external document: Dom.document = "document" @val external globalThis: {..} = "globalThis" -external null: Core__Null.t<'a> = "#null" +external null: Core__Nullable.t<'a> = "#null" external undefined: Core__Nullable.t<'a> = "#undefined" external typeof: 'a => Core__Type.t = "#typeof" From 6070da472e8f22b72d54b8f8b973ad9fa2f0aed4 Mon Sep 17 00:00:00 2001 From: Gabriel Nordeborn Date: Sun, 5 Mar 2023 09:43:18 +0100 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 38e02661..bd1d01aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ - Remove `reduceReverse` in favor of `reduceRight`. https://github.com/rescript-association/rescript-core/pull/49 - Fixed type signatures of `reduce` and `reduceWithIndex`. https://github.com/rescript-association/rescript-core/pull/49 - Add `panic`/`Error.panic`. https://github.com/rescript-association/rescript-core/pull/72 +- The globally available `null` value now originates from `Nullable` and not `Null`, just like the globally available `undefined` value does. https://github.com/rescript-association/rescript-core/pull/88 ### Documentation