feat(array): use labelled argument for length in make and init

Author: glennsl

src/Core__Array.mjs

@@ -4,21 +4,21 @@ import * as Curry from "rescript/lib/es6/curry.js";
 import * as Js_math from "rescript/lib/es6/js_math.js";
 import * as Caml_option from "rescript/lib/es6/caml_option.js";
 
-function make(len, x) {
-  if (len <= 0) {
+function make(length, x) {
+  if (length <= 0) {
     return [];
   }
-  var arr = new Array(len);
+  var arr = new Array(length);
   arr.fill(x);
   return arr;
 }
 
-function init(len, f) {
-  if (len <= 0) {
+function init(length, f) {
+  if (length <= 0) {
     return [];
   }
-  var arr = new Array(len);
-  for(var i = 0; i < len; ++i){
+  var arr = new Array(length);
+  for(var i = 0; i < length; ++i){
     arr[i] = Curry._1(f, i);
   }
   return arr;

src/Core__Array.res

@@ -19,21 +19,21 @@ external fromArrayLikeWithMap: (Js.Array2.array_like<'a>, 'a => 'b) => array<'b>
 
 @send external fillInPlace: (array<'a>, 'a, ~start: int, ~end: int) => unit = "fill"
 
-let make = (len, x) =>
-  if len <= 0 {
+let make = (~length, x) =>
+  if length <= 0 {
     []
   } else {
-    let arr = makeUninitializedUnsafe(len)
+    let arr = makeUninitializedUnsafe(length)
     arr->fillAllInPlace(x)
     arr
   }
 
-let init = (len, f) =>
-  if len <= 0 {
+let init = (~length, f) =>
+  if length <= 0 {
     []
   } else {
-    let arr = makeUninitializedUnsafe(len)
-    for i in 0 to len - 1 {
+    let arr = makeUninitializedUnsafe(length)
+    for i in 0 to length - 1 {
       arr->setUnsafe(i, f(i))
     }
     arr

src/Core__Array.resi

@@ -5,8 +5,8 @@
 external fromArrayLikeWithMap: (Js.Array2.array_like<'a>, 'a => 'b) => array<'b> = "Array.from"
 @val external fromIterator: Core__Iterator.t<'a> => array<'a> = "Array.from"
 @val external fromIteratorWithMap: (Core__Iterator.t<'a>, 'a => 'b) => array<'b> = "Array.from"
-let make: (int, 'a) => array<'a>
-let init: (int, int => 'a) => array<'a>
+let make: (~length: int, 'a) => array<'a>
+let init: (~length: int, int => 'a) => array<'a>
 @val external isArray: 'a => bool = "Array.isArray"
 @get external length: array<'a> => int = "length"
 @send external copyAllWithin: (array<'a>, ~target: int) => array<'a> = "copyWithin"