refactor(array): replace reduceReverse with native binding to reduceRight

Author: glennsl

src/Core__Array.mjs

@@ -55,15 +55,6 @@ function reduceWithIndex(a, x, f) {
   return r;
 }
 
-function reduceReverse(a, x, f) {
-  var f$1 = Curry.__2(f);
-  var r = x;
-  for(var i = a.length - 1 | 0; i >= 0; --i){
-    r = f$1(r, a[i]);
-  }
-  return r;
-}
-
 function findIndexOpt(array, finder) {
   var index = array.findIndex(finder);
   if (index !== -1) {
@@ -146,7 +137,6 @@ export {
   sort ,
   indexOfOpt ,
   lastIndexOfOpt ,
-  reduceReverse ,
   reduceWithIndex ,
   findIndexOpt ,
   reverse ,

src/Core__Array.res

@@ -139,15 +139,8 @@ let reduceWithIndexU = (a, x, f) => {
 
 let reduceWithIndex = (a, x, f) => reduceWithIndexU(a, x, (. a, b, c) => f(a, b, c))
 
-let reduceReverseU = (a, x, f) => {
-  let r = ref(x)
-  for i in length(a) - 1 downto 0 {
-    r.contents = f(. r.contents, getUnsafe(a, i))
-  }
-  r.contents
-}
-
-let reduceReverse = (a, x, f) => reduceReverseU(a, x, (. a, b) => f(a, b))
+@send
+external reduceRight: (array<'b>, ('a, 'b) => 'a, 'a) => 'a = "reduceRight"
 
 @send external some: (array<'a>, 'a => bool) => bool = "some"
 @send external someWithIndex: (array<'a>, ('a, int) => bool) => bool = "some"

src/Core__Array.resi

@@ -73,15 +73,16 @@ let lastIndexOfOpt: (array<'a>, 'a) => option<int>
 external reduce: (array<'b>, ('a, 'b) => 'a, 'a) => 'a = "reduce"
 
 /**
-  `reduceReverse(xs, init, f)`
+  `reduceRight(xs, f, init)`
 
   Works like `Array.reduce`; except that function `f` is applied to each item of `xs` from the last back to the first.
 
   ```res example
-  Array.reduceReverse(["a", "b", "c", "d"], "", (a, b) => a ++ b) == "dcba"
+  Array.reduceRight(["a", "b", "c", "d"], (a, b) => a ++ b, "") == "dcba"
   ```
 */
-let reduceReverse: (array<'b>, 'a, ('a, 'b) => 'a) => 'a
+@send
+external reduceRight: (array<'b>, ('a, 'b) => 'a, 'a) => 'a = "reduceRight"
 
 /**
   Applies `f` to each element of `xs` from beginning to end. Function `f` has three parameters: the item from the array and an “accumulator”, which starts with a value of `init` and the index of each element. `reduceWithIndex` returns the final value of the accumulator.

test/ArrayTests.mjs

@@ -82,14 +82,14 @@ Test.run([
         "ArrayTests.res",
         18,
         13,
-        28
+        26
       ],
-      "reduceReverse"
-    ], Core__Array.reduceReverse([
-          1,
-          2,
-          3
-        ], /* [] */0, Core__List.add), eq, {
+      "reduceRight"
+    ], [
+        1,
+        2,
+        3
+      ].reduceRight(Core__List.add, /* [] */0), eq, {
       hd: 1,
       tl: {
         hd: 2,
@@ -105,10 +105,10 @@ Test.run([
         "ArrayTests.res",
         23,
         20,
-        43
+        41
       ],
-      "reduceReverse - empty"
-    ], Core__Array.reduceReverse([], /* [] */0, Core__List.add), eq, /* [] */0);
+      "reduceRight - empty"
+    ], [].reduceRight(Core__List.add, /* [] */0), eq, /* [] */0);
 
 Test.run([
       [

test/ArrayTests.res

@@ -15,12 +15,12 @@ Test.run(__POS_OF__("reduce"), Array.reduce([1, 2, 3], List.add, list{}), eq, li
 Test.run(__POS_OF__("reduce - empty"), Array.reduce([], List.add, list{}), eq, list{})
 
 Test.run(
-  __POS_OF__("reduceReverse"),
-  Array.reduceReverse([1, 2, 3], list{}, List.add),
+  __POS_OF__("reduceRight"),
+  Array.reduceRight([1, 2, 3], List.add, list{}),
   eq,
   list{1, 2, 3},
 )
-Test.run(__POS_OF__("reduceReverse - empty"), Array.reduceReverse([], list{}, List.add), eq, list{})
+Test.run(__POS_OF__("reduceRight - empty"), Array.reduceRight([], List.add, list{}), eq, list{})
 
 Test.run(__POS_OF__("shuffle - length"), Array.shuffle([1, 2, 3])->Array.length, eq, 3)