Skip to content

Commit 78d0052

Browse files
committed
remove internal async/await helpers that do not need to be exposed in Core
1 parent e267806 commit 78d0052

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
- Add `Iterator.toArray` binding for turning an iterator into an array. https://github.com/rescript-association/rescript-core/pull/34
1111
- Add `Array.at` binding for returning an array item by its index. https://github.com/rescript-association/rescript-core/pull/48
1212
- Fixed type signatures of `Array.fromArrayLikeWithMap` and `Array.fromIteratorWithMap`. https://github.com/rescript-association/rescript-core/pull/50
13+
- Remove internal async/await helpers that do not need to be exposed in `Core`.
1314

1415
### Documentation
1516

src/Core__Promise.res

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,3 @@ let catch = (promise: promise<'a>, callback: exn => promise<'a>): promise<'a> =>
4747
external race: array<t<'a>> => t<'a> = "race"
4848

4949
external done: promise<'a> => unit = "%ignore"
50-
51-
external unsafe_async: 'a => promise<'a> = "%identity"
52-
external unsafe_await: promise<'a> => 'a = "?await"

src/Core__Promise.resi

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ exception TestError(string)
4040
let p = Promise.reject(TestError("some rejected value"))
4141
```
4242
*/
43-
@scope("Promise") @val
43+
@scope("Promise")
44+
@val
4445
external reject: exn => t<_> = "reject"
4546

4647
/**
@@ -224,7 +225,8 @@ race(promises)->then(winner => {
224225
})
225226
```
226227
*/
227-
@scope("Promise") @val
228+
@scope("Promise")
229+
@val
228230
external race: array<t<'a>> => t<'a> = "race"
229231

230232
/**
@@ -290,7 +292,3 @@ external all6: ((t<'a>, t<'b>, t<'c>, t<'d>, t<'e>, t<'f>)) => t<('a, 'b, 'c, 'd
290292
promise, it will raise a type error.
291293
*/
292294
external done: promise<'a> => unit = "%ignore"
293-
294-
// TODO: add docstring
295-
external unsafe_async: 'a => promise<'a> = "%identity"
296-
external unsafe_await: promise<'a> => 'a = "?await"

0 commit comments

Comments
 (0)