Remove more "empty"

Author: cknitt

migration/migration.toml

@@ -73,6 +73,10 @@ rewrite="promise<:[typeArg]>"
 match="Js.Dict.entries"
 rewrite="Dict.toArray"
 
+[js-dict-a-make]
+match="Js.Dict.empty"
+rewrite="Dict.make"
+
 [js-dict-a-keys]
 match="Js.Dict.keys"
 rewrite="Dict.keysToArray"

src/Core__Dict.res

@@ -8,7 +8,7 @@ let delete = (dict, string) => {
   delete(get(dict, string))
 }
 
-@obj external empty: unit => t<'a> = ""
+@obj external make: unit => t<'a> = ""
 
 @val external fromArray: array<(string, 'a)> => t<'a> = "Object.fromEntries"
 @val external fromIterator: Core__Iterator.t<(string, 'a)> => t<'a> = "Object.fromEntries"

src/Core__Undefined.res

@@ -2,7 +2,7 @@ type t<'a> = Js.Undefined.t<'a>
 
 external asNullable: t<'a> => Core__Nullable.t<'a> = "%identity"
 
-external empty: t<'a> = "#undefined"
+external undefined: t<'a> = "#undefined"
 
 external make: 'a => t<'a> = "%identity"
 
@@ -11,5 +11,5 @@ external toOption: t<'a> => option<'a> = "#undefined_to_opt"
 let fromOption: option<'a> => t<'a> = option =>
   switch option {
   | Some(x) => make(x)
-  | None => empty
+  | None => undefined
   }

test/TempTests.res

@@ -16,7 +16,7 @@ Console.log(date->Date.toUTCString)
 Console.info("")
 Console.info("Dict")
 Console.info("---")
-let dict = Dict.empty()
+let dict = Dict.make()
 dict->Dict.set("foo", "bar")
 let dict2 = dict->Dict.copy
 dict2->Dict.delete("foo")

test/Test.res

@@ -57,7 +57,7 @@ $codeFrame
 `
     Console.log(errorMessage)
     // API: https://nodejs.org/api/errors.html#errors_error_capturestacktrace_targetobject_constructoropt
-    let obj = Js.Obj.empty()
+    let obj = Object.empty()
     captureStackTrace(obj)
     Console.log(obj["stack"]->cleanUpStackTrace)
   }