Expand getContext variants

Author: nojaf

src/CanvasAPI.res

@@ -112,6 +112,11 @@ type canvasFillRule =
   | @as("evenodd") Evenodd
   | @as("nonzero") Nonzero
 
+type webGLPowerPreference =
+  | @as("default") Default
+  | @as("high-performance") HighPerformance
+  | @as("low-power") LowPower
+
 /**
 [See OffscreenCanvas on MDN](https://developer.mozilla.org/docs/Web/API/OffscreenCanvas)
 */
@@ -425,3 +430,17 @@ type canvasRenderingContext2DSettings = {
   mutable colorSpace?: predefinedColorSpace,
   mutable willReadFrequently?: bool,
 }
+
+type webGLContextAttributes = {
+  mutable alpha?: bool,
+  mutable depth?: bool,
+  mutable stencil?: bool,
+  mutable antialias?: bool,
+  mutable premultipliedAlpha?: bool,
+  mutable preserveDrawingBuffer?: bool,
+  mutable powerPreference?: webGLPowerPreference,
+  mutable failIfMajorPerformanceCaveat?: bool,
+  mutable desynchronized?: bool,
+}
+
+type imageBitmapRenderingContextSettings = {mutable alpha?: bool}

src/DOMAPI/HTMLCanvasElement.res

@@ -701,10 +701,10 @@ Creates a CanvasRenderingContext2D object representing a two-dimensional renderi
 [Read more on MDN](https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#2d)
 */
 @send
-external getContext2D: (
+external getContext_2D: (
   htmlCanvasElement,
   @as("2d") _,
-  ~options: canvasRenderingContext2D=?,
+  ~options: canvasRenderingContext2DSettings=?,
 ) => canvasRenderingContext2D = "getContext"
 
 /**
@@ -713,35 +713,35 @@ Returns an object that provides methods and properties for drawing and manipulat
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/getContext)
 */
 @send
-external getContext2: (
+external getContext_WebGL: (
   htmlCanvasElement,
-  ~contextId: string,
-  ~options: JSON.t=?,
-) => imageBitmapRenderingContext = "getContext"
+  @as("webgl") _,
+  ~options: webGLContextAttributes=?,
+) => webGLRenderingContext = "getContext"
 
 /**
 Returns an object that provides methods and properties for drawing and manipulating images and graphics on a canvas element in a document. A context object includes information about colors, line widths, fonts, and other graphic parameters that can be drawn on a canvas.
 @param contextId The identifier (ID) of the type of canvas to create. Internet Explorer 9 and Internet Explorer 10 support only a 2-D context using canvas.getContext("2d"); IE11 Preview also supports 3-D or WebGL context using canvas.getContext("experimental-webgl");
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/getContext)
 */
 @send
-external getContext3: (
+external getContext_WebGL2: (
   htmlCanvasElement,
-  ~contextId: string,
-  ~options: JSON.t=?,
-) => webGLRenderingContext = "getContext"
+  @as("webgl2") _,
+  ~options: webGLContextAttributes=?,
+) => webGL2RenderingContext = "getContext"
 
 /**
 Returns an object that provides methods and properties for drawing and manipulating images and graphics on a canvas element in a document. A context object includes information about colors, line widths, fonts, and other graphic parameters that can be drawn on a canvas.
 @param contextId The identifier (ID) of the type of canvas to create. Internet Explorer 9 and Internet Explorer 10 support only a 2-D context using canvas.getContext("2d"); IE11 Preview also supports 3-D or WebGL context using canvas.getContext("experimental-webgl");
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/getContext)
 */
 @send
-external getContext4: (
+external getContext_BitmapRenderer: (
   htmlCanvasElement,
-  ~contextId: string,
-  ~options: JSON.t=?,
-) => webGL2RenderingContext = "getContext"
+  @as("bitmaprenderer") _,
+  ~options: imageBitmapRenderingContextSettings=?,
+) => imageBitmapRenderingContext = "getContext"
 
 /**
 Returns the content of the current canvas as an image that you can use as a source for another canvas or an HTML element.

tests/DOMAPI/HTMLCanvasInputElement__tes.res

@@ -2,7 +2,7 @@ open WebAPI.Global
 
 let myCanvas: DOMAPI.htmlCanvasElement =
   document->Document.getElementById("myCanvas")->Prelude.unsafeConversation
-let ctx = myCanvas->HTMLCanvasElement.getContext2D
+let ctx = myCanvas->HTMLCanvasElement.getContext_2D
 
 ctx.fillStyle = Prelude.unsafeConversation("red")
 ctx->CanvasRenderingContext2D.fillRect(~x=50., ~y=50., ~w=200., ~h=200.)

tools/TypeScript-DOM-lib-generator/src/build/emitter.ts

@@ -1778,7 +1778,7 @@ export async function emitRescriptBindings(webidl: Browser.WebIdl) {
         });
     }
 
-    const interfaceHierarchy: RescriptFile[] = [
+    let interfaceHierarchy: RescriptFile[] = [
       {
         name: "Prelude",
         entries: [
@@ -2820,6 +2820,17 @@ export async function emitRescriptBindings(webidl: Browser.WebIdl) {
       },
     ];
 
+    interfaceHierarchy = [
+      {
+        name: "Temp",
+        entries: [
+          enums(["WebGLPowerPreference"]),
+          dictionaries(["ImageBitmapRenderingContextSettings", "WebGLContextAttributes"]),
+        ],
+        opens: [],
+      }
+    ]
+
     // Ensure the output folder exists.
     await fs.mkdir(outputFolder, { recursive: true });
 
@@ -2911,7 +2922,7 @@ export async function emitRescriptBindings(webidl: Browser.WebIdl) {
 
     await emitGlobalModule();
 
-    execSync("npx rescript format -all", { cwd: repoRoot, stdio: "inherit" });
+    // execSync("npx rescript format -all", { cwd: repoRoot, stdio: "inherit" });
 
     // let remainers = allInterfaces.filter((i) => {
     //   return !interfaceHierarchy.some((h) => {