review changes

Author: cknitt

belt-cppo/internal_map.cppo.res

@@ -193,7 +193,6 @@ let rec merge = (s1, s2, f) =>
   | _ => assert(false)
   }
 
-
 let rec compareAux = (e1, e2, vcmp) =>
   switch (e1, e2) {
   | (list{h1, ...t1}, list{h2, ...t2}) =>

belt-cppo/mapm.cppo.res

@@ -39,7 +39,7 @@ let forEach = (d, f) => N.forEach(d.data, f)
 let map = (d, f) => {data: N.map(d.data, f)}
 let mapWithKey = (d, f) => {data: N.mapWithKey(d.data, f)}
 let reduce = (d, acc, f) => N.reduce(d.data, acc, f)
-let every= (d, f) => N.every(d.data, f)
+let every = (d, f) => N.every(d.data, f)
 let some = (d, f) => N.some(d.data, f)
 let size = d => N.size(d.data)
 let toList = d => N.toList(d.data)

belt/src/belt.res

@@ -77,32 +77,6 @@ let greaterThan2UniqueAndSorted =
 Js.log2("result", greaterThan2UniqueAndSorted)
 ```
 
-## Curried vs. Uncurried Callbacks
-
-For functions taking a callback parameter, there are usually two versions
-available:
-
-- curried (no suffix)
-- uncurried (suffixed with `U`)
-
-E.g.:
-
-## Examples
-
-```rescript
-let forEach: (t<'a>, 'a => unit) => unit
-```
-
-The uncurried version will be faster in some cases, but for simplicity we recommend to stick with the curried version unless you need the extra performance.
-
-The two versions can be invoked as follows:
-
-## Examples
-
-```rescript
-["a", "b", "c"]->Belt.Array.forEach(x => Js.log(x))
-```
-
 ## Specialized Collections
 
 For collections types like set or map, Belt provides both a generic module as well as specialized, more efficient implementations for string and int keys.

belt/src/belt_MutableMapInt.res

@@ -32,7 +32,7 @@ let forEach = (d, f) => N.forEach(d.data, f)
 let map = (d, f) => {data: N.map(d.data, f)}
 let mapWithKey = (d, f) => {data: N.mapWithKey(d.data, f)}
 let reduce = (d, acc, f) => N.reduce(d.data, acc, f)
-let every= (d, f) => N.every(d.data, f)
+let every = (d, f) => N.every(d.data, f)
 let some = (d, f) => N.some(d.data, f)
 let size = d => N.size(d.data)
 let toList = d => N.toList(d.data)

belt/src/belt_MutableMapString.res

@@ -32,7 +32,7 @@ let forEach = (d, f) => N.forEach(d.data, f)
 let map = (d, f) => {data: N.map(d.data, f)}
 let mapWithKey = (d, f) => {data: N.mapWithKey(d.data, f)}
 let reduce = (d, acc, f) => N.reduce(d.data, acc, f)
-let every= (d, f) => N.every(d.data, f)
+let every = (d, f) => N.every(d.data, f)
 let some = (d, f) => N.some(d.data, f)
 let size = d => N.size(d.data)
 let toList = d => N.toList(d.data)

belt/src/belt_internalBuckets.js

@@ -255,21 +255,12 @@ function toArray(h) {
 
 let C;
 
-let forEachU = forEach;
-
-let reduceU = reduce;
-
-let keepMapInPlaceU = keepMapInPlace;
-
 export {
   C,
   copy,
-  forEachU,
   forEach,
-  reduceU,
   reduce,
   logStats,
-  keepMapInPlaceU,
   keepMapInPlace,
   fillArray,
   keysToArray,

belt/src/belt_internalBuckets.res

@@ -217,7 +217,3 @@ let linear = (h, f) => {
 let keysToArray = h => linear(h, x => x.key)
 let valuesToArray = h => linear(h, x => x.value)
 let toArray = h => linear(h, x => (x.key, x.value))
-
-let forEachU = forEach
-let keepMapInPlaceU = keepMapInPlace
-let reduceU = reduce

belt/src/belt_internalBuckets.resi

@@ -33,18 +33,12 @@ and t<'hash, 'eq, 'a, 'b> = C.container<'hash, 'eq, bucket<'a, 'b>>
 
 let copy: t<'hash, 'eq, 'a, 'b> => t<'hash, 'eq, 'a, 'b>
 
-@deprecated("Use `forEach` instead")
-let forEachU: (t<_, _, 'a, 'b>, ('a, 'b) => 'c) => unit
 let forEach: (t<_, _, 'a, 'b>, ('a, 'b) => 'c) => unit
 
-@deprecated("Use `reduce` instead")
-let reduceU: (t<_, _, 'a, 'b>, 'c, ('c, 'a, 'b) => 'c) => 'c
 let reduce: (t<_, _, 'a, 'b>, 'c, ('c, 'a, 'b) => 'c) => 'c
 
 let logStats: t<_> => unit
 
-@deprecated("Use `keepMapInPlace` instead")
-let keepMapInPlaceU: (t<_, _, 'a, 'b>, ('a, 'b) => option<'b>) => unit
 let keepMapInPlace: (t<_, _, 'a, 'b>, ('a, 'b) => option<'b>) => unit
 
 let fillArray: (int, array<('a, 'b)>, bucket<'a, 'b>) => int

belt/src/belt_internalMapInt.res

@@ -187,7 +187,6 @@ let rec merge = (s1, s2, f) =>
   | _ => assert(false)
   }
 
-
 let rec compareAux = (e1, e2, vcmp) =>
   switch (e1, e2) {
   | (list{h1, ...t1}, list{h2, ...t2}) =>

belt/src/belt_internalMapString.res

@@ -187,7 +187,6 @@ let rec merge = (s1, s2, f) =>
   | _ => assert(false)
   }
 
-
 let rec compareAux = (e1, e2, vcmp) =>
   switch (e1, e2) {
   | (list{h1, ...t1}, list{h2, ...t2}) =>