Skip to content

Commit 3c1d48f

Browse files
patrick91vladvildanov
authored andcommitted
Add return type to close functions (#3496)
1 parent 5a39da0 commit 3c1d48f

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

redis/client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ def __exit__(self, exc_type, exc_value, traceback):
550550
def __del__(self):
551551
self.close()
552552

553-
def close(self):
553+
def close(self) -> None:
554554
# In case a connection property does not yet exist
555555
# (due to a crash earlier in the Redis() constructor), return
556556
# immediately as there is nothing to clean-up.
@@ -1551,7 +1551,6 @@ def _disconnect_raise_reset(
15511551
conn.retry_on_error is None
15521552
or isinstance(error, tuple(conn.retry_on_error)) is False
15531553
):
1554-
15551554
self.reset()
15561555
raise error
15571556

redis/cluster.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1244,7 +1244,7 @@ def _execute_command(self, target_node, *args, **kwargs):
12441244

12451245
raise ClusterError("TTL exhausted.")
12461246

1247-
def close(self):
1247+
def close(self) -> None:
12481248
try:
12491249
with self._lock:
12501250
if self.nodes_manager:
@@ -1686,7 +1686,7 @@ def initialize(self):
16861686
# If initialize was called after a MovedError, clear it
16871687
self._moved_exception = None
16881688

1689-
def close(self):
1689+
def close(self) -> None:
16901690
self.default_node = None
16911691
for node in self.nodes_cache.values():
16921692
if node.redis_connection:

0 commit comments

Comments
 (0)