Skip to content

Commit 29f80a5

Browse files
authored
Fix GRAPH.LIST & TDIGEST.QUANTILE tests (#2335)
* fix graph list_keys test * async test * fix tdigest.quantile * fix
1 parent 2cea637 commit 29f80a5

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

tests/test_asyncio/test_bloom.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -366,21 +366,21 @@ async def test_tdigest_quantile(modclient: redis.Redis):
366366
# assert min min/max have same result as quantile 0 and 1
367367
assert (
368368
await modclient.tdigest().max("tDigest")
369-
== (await modclient.tdigest().quantile("tDigest", 1.0))[1]
369+
== (await modclient.tdigest().quantile("tDigest", 1.0))[0]
370370
)
371371
assert (
372372
await modclient.tdigest().min("tDigest")
373-
== (await modclient.tdigest().quantile("tDigest", 0.0))[1]
373+
== (await modclient.tdigest().quantile("tDigest", 0.0))[0]
374374
)
375375

376-
assert 1.0 == round((await modclient.tdigest().quantile("tDigest", 0.01))[1], 2)
377-
assert 99.0 == round((await modclient.tdigest().quantile("tDigest", 0.99))[1], 2)
376+
assert 1.0 == round((await modclient.tdigest().quantile("tDigest", 0.01))[0], 2)
377+
assert 99.0 == round((await modclient.tdigest().quantile("tDigest", 0.99))[0], 2)
378378

379379
# test multiple quantiles
380380
assert await modclient.tdigest().create("t-digest", 100)
381381
assert await modclient.tdigest().add("t-digest", [1, 2, 3, 4, 5], [1.0] * 5)
382382
res = await modclient.tdigest().quantile("t-digest", 0.5, 0.8)
383-
assert [0.5, 3.0, 0.8, 5.0] == res
383+
assert [3.0, 5.0] == res
384384

385385

386386
@pytest.mark.redismod

tests/test_asyncio/test_graph.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,11 +348,11 @@ async def test_list_keys(modclient: redis.Redis):
348348
result = await modclient.graph().list_keys()
349349
assert result == []
350350

351-
await modclient.execute_command("GRAPH.EXPLAIN", "G", "RETURN 1")
351+
await modclient.graph("G").query("CREATE (n)")
352352
result = await modclient.graph().list_keys()
353353
assert result == ["G"]
354354

355-
await modclient.execute_command("GRAPH.EXPLAIN", "X", "RETURN 1")
355+
await modclient.graph("X").query("CREATE (m)")
356356
result = await modclient.graph().list_keys()
357357
assert result == ["G", "X"]
358358

tests/test_bloom.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -365,17 +365,17 @@ def test_tdigest_quantile(client):
365365
)
366366
# assert min min/max have same result as quantile 0 and 1
367367
res = client.tdigest().quantile("tDigest", 1.0)
368-
assert client.tdigest().max("tDigest") == res[1]
368+
assert client.tdigest().max("tDigest") == res[0]
369369
res = client.tdigest().quantile("tDigest", 0.0)
370-
assert client.tdigest().min("tDigest") == res[1]
370+
assert client.tdigest().min("tDigest") == res[0]
371371

372-
assert 1.0 == round(client.tdigest().quantile("tDigest", 0.01)[1], 2)
373-
assert 99.0 == round(client.tdigest().quantile("tDigest", 0.99)[1], 2)
372+
assert 1.0 == round(client.tdigest().quantile("tDigest", 0.01)[0], 2)
373+
assert 99.0 == round(client.tdigest().quantile("tDigest", 0.99)[0], 2)
374374

375375
# test multiple quantiles
376376
assert client.tdigest().create("t-digest", 100)
377377
assert client.tdigest().add("t-digest", [1, 2, 3, 4, 5], [1.0] * 5)
378-
assert [0.5, 3.0, 0.8, 5.0] == client.tdigest().quantile("t-digest", 0.5, 0.8)
378+
assert [3.0, 5.0] == client.tdigest().quantile("t-digest", 0.5, 0.8)
379379

380380

381381
@pytest.mark.redismod

tests/test_graph.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,11 +366,11 @@ def test_list_keys(client):
366366
result = client.graph().list_keys()
367367
assert result == []
368368

369-
client.execute_command("GRAPH.EXPLAIN", "G", "RETURN 1")
369+
client.graph("G").query("CREATE (n)")
370370
result = client.graph().list_keys()
371371
assert result == ["G"]
372372

373-
client.execute_command("GRAPH.EXPLAIN", "X", "RETURN 1")
373+
client.graph("X").query("CREATE (m)")
374374
result = client.graph().list_keys()
375375
assert result == ["G", "X"]
376376

0 commit comments

Comments
 (0)