Fix integration workflow bugs

Author: uglide

.github/actions/run-tests/action.yml

@@ -78,6 +78,8 @@ runs:
 
     - name: Run tests
       run: |
+        set -e
+        
         run_tests() {
           local protocol=$1
           local eventloop=""
@@ -88,7 +90,7 @@ runs:
 
           echo "::group::RESP${protocol} standalone tests"
           echo "REDIS_MOD_URL=${REDIS_MOD_URL}"
-          invoke standalone-tests --redis-mod-url=${REDIS_MOD_URL} $eventloop --protocol=${protocol}
+          invoke standalone-tests --redis-mod-url=${REDIS_MOD_URL} $eventloop --protocol="${protocol}"
           echo "::endgroup::"
 
           if [ "$protocol" == "2" ] || [ "${{inputs.parser-backend}}" != 'hiredis' ]; then
@@ -98,18 +100,26 @@ runs:
           fi
         }
 
-        run_tests 2
-        run_tests 3
+        run_tests 2 "${{inputs.event-loop}}"
+        run_tests 3 "${{inputs.event-loop}}"
       shell: bash
 
     - name: Debug
       if: failure()
       run: |
+        sudo apt-get install -y redis-tools
         echo "Docker Containers:"
         docker ps
         redis-cli -p 16379 CLUSTER NODES
       shell: bash
 
+    - name: Setup upterm session
+      if: failure()
+      uses: lhotari/action-upterm@v1
+      with:
+        limit-access-to-actor: true
+        limit-access-to-users: uglide
+
     - name: Upload test results and profiling data
       uses: actions/upload-artifact@v4
       with:

.github/workflows/integration.yaml

@@ -57,14 +57,24 @@ jobs:
           pip install -r dev_requirements.txt
           invoke linters
 
+  redis_version:
+    runs-on: ubuntu-latest
+    outputs:
+      CURRENT: ${{ env.CURRENT_REDIS_VERSION }}
+    steps:
+      - name: Compute outputs
+        run: |
+          echo "CURRENT=${{ env.CURRENT_REDIS_VERSION }}" >> $GITHUB_OUTPUT
+
   tests:
     runs-on: ubuntu-latest
     timeout-minutes: 60
+    needs: redis_version
     strategy:
       max-parallel: 15
       fail-fast: false
       matrix:
-        redis-version: [${{ env.CURRENT_REDIS_VERSION }}] #, '8.0-M01', '7.2.6', '6.2.16']
+        redis-version: [ '${{ needs.redis_version.outputs.CURRENT }}' ] #, '8.0-M01', '7.2.6', '6.2.16']
         python-version: ['3.8', '3.12']
         parser-backend: ['plain']
         event-loop: ['asyncio']
@@ -82,13 +92,13 @@ jobs:
 
   python-compatibility-tests:
     runs-on: ubuntu-latest
-    needs: [ tests ]
+    needs: [ redis_version, tests ]
     timeout-minutes: 60
     strategy:
       max-parallel: 15
       fail-fast: false
       matrix:
-        redis-version: [ ${{ env.CURRENT_REDIS_VERSION }}]
+        redis-version: [ '${{ needs.redis_version.outputs.CURRENT }}' ]
         python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.9', 'pypy-3.10']
         parser-backend: [ 'plain' ]
         event-loop: [ 'asyncio' ]
@@ -106,13 +116,13 @@ jobs:
 
   hiredis-tests:
     runs-on: ubuntu-latest
-    needs: [tests]
+    needs: [redis_version, tests]
     timeout-minutes: 60
     strategy:
       max-parallel: 15
       fail-fast: false
       matrix:
-        redis-version: [ ${{ env.CURRENT_REDIS_VERSION }} ]
+        redis-version: [ '${{ needs.redis_version.outputs.CURRENT }}' ]
         python-version: [ '3.8', '3.12']
         parser-backend: [ 'hiredis' ]
         event-loop: [ 'asyncio' ]
@@ -139,13 +149,13 @@ jobs:
 
   uvloop-tests:
     runs-on: ubuntu-latest
-    needs: [tests]
+    needs: [redis_version, tests]
     timeout-minutes: 60
     strategy:
       max-parallel: 15
       fail-fast: false
       matrix:
-        redis-version: [ ${{ env.CURRENT_REDIS_VERSION }} ]
+        redis-version: [ '${{ needs.redis_version.outputs.CURRENT }}' ]
         python-version: [ '3.8', '3.12' ]
         parser-backend: [ 'plain' ]
         event-loop: [ 'uvloop' ]

docker-compose.yml

@@ -10,7 +10,7 @@ services:
       - REDIS_CLUSTER=no
       - PORT=6379
       - TLS_PORT=6666
-    command: --enable-debug-command yes --tls-auth-clients optional
+    command: --enable-debug-command yes --tls-auth-clients optional --save ""
     ports:
       - 6379:6379
       - 6666:6666 # TLS port
@@ -28,7 +28,7 @@ services:
     container_name: redis-replica
     depends_on:
       - redis
-    command: redis-server --replicaof redis 6379 --protected-mode no
+    command: redis-server --replicaof redis 6379 --protected-mode no --save ""
     ports:
       - 6380:6379
     profiles:
@@ -46,7 +46,7 @@ services:
       - TLS_ENABLED=yes
       - PORT=16379
       - TLS_PORT=27379
-    command: --enable-debug-command yes --tls-auth-clients optional
+    command: --enable-debug-command yes --tls-auth-clients optional --save ""
     ports:
       - "16379-16384:16379-16384"
       - "27379-27384:27379-27384"
@@ -108,7 +108,7 @@ services:
     ports:
       - 6479:6379
     environment:
-      - "REDIS_ARGS=--enable-debug-command yes --enable-module-command yes"
+      - "REDIS_ARGS=--enable-debug-command yes --enable-module-command yes --save ''"
     profiles:
       - standalone
       - all-stack