address most of my review comments

Author: sjpotter

packages/client/lib/commands/COMMAND_GETKEYS.ts

@@ -6,7 +6,7 @@ export default {
   IS_READ_ONLY: true,
   parseCommand(parser: CommandParser, args: Array<RedisArgument>) {
     parser.push('COMMAND', 'GETKEYS');
-    parser.pushVariadic(args);
+    parser.push(...args);
   },
   transformReply: undefined as unknown as () => ArrayReply<BlobStringReply>
 } as const satisfies Command;

packages/client/lib/commands/COMMAND_GETKEYSANDFLAGS.ts

@@ -11,7 +11,7 @@ export default {
   IS_READ_ONLY: true,
   parseCommand(parser: CommandParser, args: Array<RedisArgument>) {
     parser.push('COMMAND', 'GETKEYSANDFLAGS');
-    parser.pushVariadic(args);
+    parser.push(...args);
   },
   transformReply(reply: UnwrapReply<CommandGetKeysAndFlagsRawReply>) {
     return reply.map(entry => {

packages/client/lib/commands/COMMAND_INFO.ts

@@ -6,8 +6,7 @@ export default {
   NOT_KEYED_COMMAND: true,
   IS_READ_ONLY: true,
   parseCommand(parser: CommandParser, commands: Array<string>) {
-    parser.push('COMMAND', 'INFO');
-    parser.pushVariadic(commands);
+    parser.push('COMMAND', 'INFO', ...commands);
   },
   // TODO: This works, as we don't currently handle any of the items returned as a map
   transformReply(reply: UnwrapReply<ArrayReply<CommandRawReply>>): Array<CommandReply | null> {

packages/client/lib/commands/EVAL.ts

@@ -19,7 +19,7 @@ export function parseEvalArguments(
   }
 
   if (options?.arguments) {
-    parser.pushVariadic(options.arguments)
+    parser.push(...options.arguments)
   }
 }
 

packages/client/lib/commands/GEORADIUSBYMEMBER_WITH.ts

@@ -17,7 +17,7 @@ export function parseGeoRadiusByMemberWithArguments(
   parser.push(from, radius.toString(), unit);
   parseGeoSearchOptions(parser, options);
 
-  parser.pushVariadic(replyWith);
+  parser.push(...replyWith);
   parser.setPreserve(replyWith);
 }
 

packages/client/lib/commands/GEOSEARCH_WITH.ts

@@ -31,7 +31,7 @@ export default {
     options?: GeoSearchOptions
   ) {
     GEOSEARCH.parseCommand(parser, key, from, by, options);
-    parser.pushVariadic(replyWith);
+    parser.push(...replyWith);
     parser.setPreserve(replyWith);
   },
   transformReply(

packages/client/lib/commands/GETRANGE.ts

@@ -7,8 +7,7 @@ export default {
     parser.setCachable();
     parser.push('GETRANGE');
     parser.pushKey(key);
-    parser.push(start.toString());
-    parser.push(end.toString());
+    parser.push(start.toString(), end.toString());
   },
   transformReply: undefined as unknown as () => BlobStringReply | NullReply
 } as const satisfies Command;

packages/client/lib/commands/MODULE_LOAD.ts

@@ -8,7 +8,7 @@ export default {
     parser.push('MODULE', 'LOAD', path);
 
     if (moduleArguments) {
-      parser.pushVariadic(moduleArguments);
+      parser.push(...moduleArguments);
     }
   },
   transformReply: undefined as unknown as () => SimpleStringReply<'OK'>

packages/client/lib/commands/UNLINK.ts

@@ -6,7 +6,7 @@ export default {
   IS_READ_ONLY: false,
   parseCommand(parser: CommandParser, keys: RedisVariadicArgument) {
     parser.push('UNLINK');
-    parser.pushVariadic(keys);
+    parser.pushKeys(keys);
   },
   transformReply: undefined as unknown as () => NumberReply
 } as const satisfies Command;

packages/client/lib/commands/ZCOUNT.ts

@@ -12,7 +12,7 @@ export default {
   ) {
     parser.setCachable();
     parser.push('ZCOUNT');
-    parser.push(key);
+    parser.pushKey(key);
     parser.push(
       transformStringDoubleArgument(min), 
       transformStringDoubleArgument(max)

packages/client/lib/commands/ZINTER_WITHSCORES.ts

@@ -1,14 +1,13 @@
-import { CommandParser } from '../client/parser';
 import { Command } from '../RESP/types';
-import { Tail, transformSortedSetReply } from './generic-transformers';
+import { transformSortedSetReply } from './generic-transformers';
 import ZINTER from './ZINTER';
 
 
 export default {
   IS_READ_ONLY: ZINTER.IS_READ_ONLY,
-  parseCommand(parser: CommandParser, ...args: Tail<Parameters<typeof ZINTER.parseCommand>>) {
-    ZINTER.parseCommand(parser, ...args);
-    parser.push('WITHSCORES');
+  parseCommand(...args: Parameters<typeof ZINTER.parseCommand>) {
+    ZINTER.parseCommand(...args);
+    args[0].push('WITHSCORES');
   },
   transformReply: transformSortedSetReply
 } as const satisfies Command;

packages/client/lib/commands/ZRANGEBYLEX.ts

@@ -23,7 +23,7 @@ export default {
     parser.pushKey(key);
     parser.push(
       transformStringDoubleArgument(min),
-      transformStringDoubleArgument(max),
+      transformStringDoubleArgument(max)
     );
 
     if (options?.LIMIT) {

packages/client/lib/commands/generic-transformers.ts

@@ -347,13 +347,13 @@ export function transformCommandReply(
   [name, arity, flags, firstKeyIndex, lastKeyIndex, step, categories]: CommandRawReply
 ): CommandReply {
   return {
-      name,
-      arity,
-      flags: new Set(flags),
-      firstKeyIndex,
-      lastKeyIndex,
-      step,
-      categories: new Set(categories)
+    name,
+    arity,
+    flags: new Set(flags),
+    firstKeyIndex,
+    lastKeyIndex,
+    step,
+    categories: new Set(categories)
   };
 }
 

packages/client/lib/commands/index.ts

@@ -1030,7 +1030,3 @@ export default {
   ZUNIONSTORE,
   zUnionStore: ZUNIONSTORE
 } as const satisfies RedisCommands;
-/**
- * @readonly
- * @enum {number}
- */