chore: instrumentation name and version (#2012)

nelz9999 · web-flow · commit 3ecadf5f8705 · 2022-02-02T09:26:14.000+02:00
diff --git a/extra/redisotel/redisotel.go b/extra/redisotel/redisotel.go
@@ -14,8 +14,7 @@ import (
 )
 
 const (
-	// todo: consider using the full module path "github.com/go-redis/redis/extra/redisotel"
-	defaultTracerName = "github.com/go-redis/redis"
+	defaultTracerName = "github.com/go-redis/redis/extra/redisotel"
 )
 
 type TracingHook struct {
@@ -32,8 +31,7 @@ func NewTracingHook(opts ...Option) *TracingHook {
 
 	tracer := cfg.tp.Tracer(
 		defaultTracerName,
-		// todo: consider adding a version
-		// trace.WithInstrumentationVersion("semver:8.11.4"),
+		trace.WithInstrumentationVersion("semver:"+redis.Version()),
 	)
 	return &TracingHook{tracer: tracer}
 }

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,7 @@ import (`
`14`	`14`	`)`
`15`	`15`
`16`	`16`	`const (`
`17`		`- // todo: consider using the full module path "github.com/go-redis/redis/extra/redisotel"`
`18`		`- defaultTracerName = "github.com/go-redis/redis"`
	`17`	`+ defaultTracerName = "github.com/go-redis/redis/extra/redisotel"`
`19`	`18`	`)`
`20`	`19`
`21`	`20`	`type TracingHook struct {`
`@@ -32,8 +31,7 @@ func NewTracingHook(opts ...Option) *TracingHook {`
`32`	`31`
`33`	`32`	`tracer := cfg.tp.Tracer(`
`34`	`33`	`defaultTracerName,`
`35`		`- // todo: consider adding a version`
`36`		`- // trace.WithInstrumentationVersion("semver:8.11.4"),`
	`34`	`+ trace.WithInstrumentationVersion("semver:"+redis.Version()),`
`37`	`35`	`)`
`38`	`36`	`return &TracingHook{tracer: tracer}`
`39`	`37`	`}`