Skip to content

Commit fb502e2

Browse files
committed
Mark FulfilledPromise and RejectedPromise as deprecated
Use `resolve()` and `reject()` instead.
1 parent 0f37290 commit fb502e2

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

README.md

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -173,9 +173,9 @@ Neither its state nor its result (or error) can be modified.
173173
#### Implementations
174174

175175
* [Promise](#promise-2)
176-
* [FulfilledPromise](#fulfilledpromise)
177-
* [RejectedPromise](#rejectedpromise)
178-
* [LazyPromise](#lazypromise)
176+
* [FulfilledPromise](#fulfilledpromise) (deprecated)
177+
* [RejectedPromise](#rejectedpromise) (deprecated)
178+
* [LazyPromise](#lazypromise) (deprecated)
179179

180180
#### PromiseInterface::then()
181181

@@ -225,9 +225,9 @@ and utility methods which are not part of the Promises/A specification.
225225
#### Implementations
226226

227227
* [Promise](#promise-1)
228-
* [FulfilledPromise](#fulfilledpromise)
229-
* [RejectedPromise](#rejectedpromise)
230-
* [LazyPromise](#lazypromise)
228+
* [FulfilledPromise](#fulfilledpromise) (deprecated)
229+
* [RejectedPromise](#rejectedpromise) (deprecated)
230+
* [LazyPromise](#lazypromise) (deprecated)
231231

232232
#### ExtendedPromiseInterface::done()
233233

@@ -357,9 +357,9 @@ a promise has no effect.
357357
#### Implementations
358358

359359
* [Promise](#promise-1)
360-
* [FulfilledPromise](#fulfilledpromise)
361-
* [RejectedPromise](#rejectedpromise)
362-
* [LazyPromise](#lazypromise)
360+
* [FulfilledPromise](#fulfilledpromise) (deprecated)
361+
* [RejectedPromise](#rejectedpromise) (deprecated)
362+
* [LazyPromise](#lazypromise) (deprecated)
363363

364364
### Promise
365365

@@ -409,6 +409,8 @@ once all consumers called the `cancel()` method of the promise.
409409

410410
### FulfilledPromise
411411

412+
> Deprecated in v2.8.0: External usage of `FulfilledPromise` is deprecated, use `resolve()` instead.
413+
412414
Creates a already fulfilled promise.
413415

414416
```php
@@ -420,6 +422,8 @@ Note, that `$value` **cannot** be a promise. It's recommended to use
420422

421423
### RejectedPromise
422424

425+
> Deprecated in v2.8.0: External usage of `RejectedPromise` is deprecated, use `reject()` instead.
426+
423427
Creates a already rejected promise.
424428

425429
```php

src/FulfilledPromise.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace React\Promise;
44

5+
/**
6+
* @deprecated 2.8.0 External usage of FulfilledPromise is deprecated, use `resolve()` instead.
7+
*/
58
class FulfilledPromise implements ExtendedPromiseInterface, CancellablePromiseInterface
69
{
710
private $value;

src/RejectedPromise.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace React\Promise;
44

5+
/**
6+
* @deprecated 2.8.0 External usage of RejectedPromise is deprecated, use `reject()` instead.
7+
*/
58
class RejectedPromise implements ExtendedPromiseInterface, CancellablePromiseInterface
69
{
710
private $reason;

0 commit comments

Comments
 (0)