Skip to content

Commit 4b155a2

Browse files
committed
PR changes
1 parent de3bd87 commit 4b155a2

File tree

4 files changed

+136
-107
lines changed

4 files changed

+136
-107
lines changed

src/components/StickyResponsiveSidebar/StickyResponsiveSidebar.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class StickyResponsiveSidebar extends Component {
149149
}}
150150
onClick={this._openNavMenu}
151151
role="button"
152-
tabIndex="-1">
152+
tabIndex={0}>
153153
<Container>
154154
<div
155155
css={{

src/templates/components/MetaTitle/index.js

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,17 @@
1212
import React from 'react';
1313
import {colors} from 'theme';
1414

15-
const MetaTitle = ({
16-
children,
17-
title,
18-
cssProps = {},
19-
onClick,
20-
onDark = false,
21-
}) => (
15+
const MetaTitle = ({children, title, cssProps = {}, onDark = false}) => (
2216
<div
23-
onClick={onClick}
2417
css={{
2518
color: onDark ? colors.subtleOnDark : colors.subtle,
26-
cursor: onClick ? 'pointer' : null,
2719
fontSize: 14,
2820
fontWeight: 700,
2921
lineHeight: 3,
3022
textTransform: 'uppercase',
3123
letterSpacing: '0.08em',
3224
...cssProps,
33-
}}
34-
role="link"
35-
tabIndex="-1">
25+
}}>
3626
{children}
3727
</div>
3828
);

src/templates/components/Sidebar/Section.js

Lines changed: 25 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -26,32 +26,35 @@ const Section = ({
2626
section,
2727
}) => (
2828
<div>
29-
<MetaTitle
30-
onClick={onSectionTitleClick}
31-
cssProps={{
32-
marginTop: 10,
29+
<button
30+
css={{cursor: 'pointer', backgroundColor: 'transparent', border: 0}}
31+
onClick={onSectionTitleClick}>
32+
<MetaTitle
33+
cssProps={{
34+
marginTop: 10,
3335

34-
[media.greaterThan('small')]: {
35-
color: isActive ? colors.text : colors.subtle,
36+
[media.greaterThan('small')]: {
37+
color: isActive ? colors.text : colors.subtle,
3638

37-
':hover': {
38-
color: colors.text,
39+
':hover': {
40+
color: colors.text,
41+
},
3942
},
40-
},
41-
}}>
42-
{section.title}
43-
<ChevronSvg
44-
cssProps={{
45-
marginLeft: 7,
46-
transform: isActive ? 'rotateX(180deg)' : 'rotateX(0deg)',
47-
transition: 'transform 0.2s ease',
43+
}}>
44+
{section.title}
45+
<ChevronSvg
46+
cssProps={{
47+
marginLeft: 7,
48+
transform: isActive ? 'rotateX(180deg)' : 'rotateX(0deg)',
49+
transition: 'transform 0.2s ease',
4850

49-
[media.lessThan('small')]: {
50-
display: 'none',
51-
},
52-
}}
53-
/>
54-
</MetaTitle>
51+
[media.lessThan('small')]: {
52+
display: 'none',
53+
},
54+
}}
55+
/>
56+
</MetaTitle>
57+
</button>
5558
<ul
5659
css={{
5760
marginBottom: 10,

0 commit comments

Comments
 (0)