Skip to content

Commit ba1e257

Browse files
committed
remove assertions on data-reactroot
see facebook/react#10971
1 parent 098f2df commit ba1e257

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

test/react/server_rendering/bundle_renderer_test.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ class BundleRendererTest < ActiveSupport::TestCase
3333
test '#render returns HTML' do
3434
result = @renderer.render('Todo', { todo: 'write tests' }, nil)
3535
assert_match(/<li.*write tests<\/li>/, result)
36-
assert_match(/data-reactroot/, result)
3736
end
3837

3938
test '#render accepts strings' do
@@ -44,7 +43,6 @@ class BundleRendererTest < ActiveSupport::TestCase
4443
test '#render accepts :static pre-render option' do
4544
result = @renderer.render('Todo', { todo: 'write more tests' }, :static)
4645
assert_match(/<li>write more tests<\/li>/, result)
47-
assert_no_match(/data-reactroot/, result)
4846
end
4947

5048
test '#render replays console messages' do

test/react/server_rendering/exec_js_renderer_test.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,13 @@ class ExecJSRendererTest < ActiveSupport::TestCase
2323

2424
test '#render returns HTML' do
2525
result = @renderer.render('Todo', { todo: 'write tests' }.to_json, {})
26+
p result
2627
assert_match(/<li.*write tests<\/li>/, result)
27-
assert_match(/data-reactroot/, result)
2828
end
2929

3030
test '#render accepts render_function:' do
3131
result = @renderer.render('Todo', { todo: 'write more tests' }.to_json, render_function: 'renderToStaticMarkup')
3232
assert_match(/<li>write more tests<\/li>/, result)
33-
assert_no_match(/data-reactroot/, result)
3433
end
3534

3635
test '#before_render is called before #after_render' do

0 commit comments

Comments
 (0)