Skip to content

Commit b07477e

Browse files
committed
remove assertions on data-reactroot
see facebook/react#10971
1 parent 2367c2a commit b07477e

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

test/react/server_rendering/bundle_renderer_test.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ class BundleRendererTest < ActiveSupport::TestCase
3636
result = @renderer.render("Todo", { todo: "write tests" }, nil)
3737

3838
assert_match(%r{<li.*write tests</li>}, result)
39-
assert_match(/data-reactroot/, result)
4039
end
4140

4241
test "#render accepts strings" do
@@ -49,7 +48,6 @@ class BundleRendererTest < ActiveSupport::TestCase
4948
result = @renderer.render("Todo", { todo: "write more tests" }, :static)
5049

5150
assert_match(%r{<li>write more tests</li>}, result)
52-
assert_no_match(/data-reactroot/, result)
5351
end
5452

5553
test "#render replays console messages" do # rubocop:disable Minitest/MultipleAssertions

test/react/server_rendering/exec_js_renderer_test.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,12 @@ class ExecJSRendererTest < ActiveSupport::TestCase
3232
result = @renderer.render("Todo", { todo: "write tests" }.to_json, {})
3333

3434
assert_match(%r{<li.*write tests</li>}, result)
35-
assert_match(/data-reactroot/, result)
3635
end
3736

3837
test "#render accepts render_function:" do
3938
result = @renderer.render("Todo", { todo: "write more tests" }.to_json, render_function: "renderToStaticMarkup")
4039

4140
assert_match(%r{<li>write more tests</li>}, result)
42-
assert_no_match(/data-reactroot/, result)
4341
end
4442

4543
test "#before_render is called before #after_render" do

0 commit comments

Comments
 (0)