update test suite

Author: Judahmeek

.github/workflows/ruby.yml

@@ -19,6 +19,10 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - uses: actions/setup-node@v3
+    - run: npm -g install yalc
+    - run: yalc publish
+    - run: cd test/dummy_shakapacker && yalc add react_ujs
+    - run: cd test/dummy_shakapacker && yarn
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: 2.7.3

.gitignore

@@ -7,3 +7,5 @@ test/*/public/packs
 **/node_modules
 react-builds/build
 coverage/
+**/.yalc
+**/yalc.*

Rakefile

@@ -70,14 +70,14 @@ namespace :ujs do
   end
 end
 
-require 'rake/testtask'
+require "minitest/test_task"
 
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = ENV['TEST_PATTERN'] || 'test/**/*_test.rb'
-  t.verbose = ENV['TEST_VERBOSE'] == '1'
+Minitest::TestTask.create(:test) do |t|
+  t.libs << "test"
+  t.libs << "lib"
   t.warning = false
+  t.test_globs = ENV['TEST_PATTERN'] || 'test/**/*_test.rb'
+  t.verbose = ENV['TEST_VERBOSE'] == '1'
 end
 
 task default: :test

test/dummy_shakapacker/babel.config.js

@@ -2,6 +2,7 @@ module.exports = function (api) {
   const defaultConfigFunc = require('shakapacker/package/babel/preset.js')
   const resultConfig = defaultConfigFunc(api)
   const isProductionEnv = api.env('production')
+  const isDevelopmentEnv = api.env('development')
 
   const changesOnDefault = {
     presets: [
@@ -15,6 +16,12 @@ module.exports = function (api) {
     ].filter(Boolean),
     plugins: [
       process.env.WEBPACK_SERVE && 'react-refresh/babel',
+      !isDevelopmentEnv && [
+        'babel-plugin-transform-react-remove-prop-types',
+        {
+          removeImport: true,
+        },
+      ],
     ].filter(Boolean),
   }
 

test/dummy_shakapacker/bin/webpack

@@ -0,0 +1,15 @@
+#!/usr/bin/env ruby
+
+require "pathname"
+require "bundler/setup"
+require "webpacker"
+require "webpacker/webpack_runner"
+
+ENV["RAILS_ENV"] ||= "development"
+ENV["NODE_ENV"]  ||= ENV["RAILS_ENV"]
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", Pathname.new(__FILE__).realpath)
+
+APP_ROOT = File.expand_path("..", __dir__)
+Dir.chdir(APP_ROOT) do
+  Webpacker::WebpackRunner.run(ARGV)
+end

test/dummy_shakapacker/bin/webpack-dev-server

@@ -0,0 +1,18 @@
+#!/usr/bin/env ruby
+
+ENV["RAILS_ENV"] ||= "development"
+ENV["NODE_ENV"]  ||= ENV["RAILS_ENV"]
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+require "bundler/setup"
+
+require "webpacker"
+require "webpacker/dev_server_runner"
+
+APP_ROOT = File.expand_path("..", __dir__)
+Dir.chdir(APP_ROOT) do
+  Webpacker::DevServerRunner.run(ARGV)
+end

test/dummy_shakapacker/bin/webpacker

@@ -7,7 +7,7 @@ const configureClient = () => {
   // In case this entry is not deleted, a very strange "window" not found
   // error shows referring to window["webpackJsonp"]. That is because the
   // client config is going to try to load chunks.
-  delete clientConfig.entry['server-bundle']
+  delete clientConfig.entry['server_rendering']
 
   return clientConfig
 }

test/dummy_shakapacker/bin/webpacker-dev-server

@@ -12,11 +12,11 @@ const configureServer = () => {
 
   // We just want the single server bundle entry
   const serverEntry = {
-    'server-bundle': serverWebpackConfig.entry['server-bundle']
+    'server_rendering': serverWebpackConfig.entry['server_rendering']
   }
 
-  if (!serverEntry['server-bundle']) {
-    throw new Error('Create a pack with the file name \'server-bundle.js\' containing all the server rendering files')
+  if (!serverEntry['server_rendering']) {
+    throw new Error('Create a pack with the file name \'server_rendering.js\' containing all the server rendering files')
   }
 
   serverWebpackConfig.entry = serverEntry
@@ -41,10 +41,10 @@ const configureServer = () => {
     new webpack.optimize.LimitChunkCountPlugin({ maxChunks: 1 })
   )
 
-  // Custom output for the server-bundle that matches the config in
+  // Custom output for the server_rendering that matches the config in
   // config/initializers/react_on_rails.rb
   serverWebpackConfig.output = {
-    filename: 'server-bundle.js',
+    filename: 'server_rendering.js',
     globalObject: 'this',
     // If using the React on Rails Pro node server renderer, uncomment the next line
     // libraryTarget: 'commonjs2',

test/dummy_shakapacker/config/webpack/clientWebpackConfig.js

@@ -0,0 +1,15 @@
+const { env, webpackConfig } = require('shakapacker');
+const { existsSync } = require('fs');
+const { resolve } = require('path');
+
+const envSpecificConfig = () => {
+  const path = resolve(__dirname, `${env.nodeEnv}.js`);
+  if (existsSync(path)) {
+    console.log(`Loading ENV specific webpack configuration file ${path}`);
+    return require(path);
+  } else {
+    return webpackConfig;
+  }
+};
+
+module.exports = envSpecificConfig();

test/dummy_shakapacker/config/webpack/serverWebpackConfig.js

@@ -13,22 +13,6 @@ default: &default
   # Reload manifest.json on all requests so we reload latest compiled packs
   cache_manifest: false
 
-  extensions:
-    - .coffee
-    - .erb
-    - .js
-    - .jsx
-    - .ts
-    - .vue
-    - .sass
-    - .scss
-    - .css
-    - .png
-    - .svg
-    - .gif
-    - .jpeg
-    - .jpg
-
 development:
   <<: *default
   compile: true

test/dummy_shakapacker/config/webpack/webpack.config.js

@@ -9,12 +9,14 @@
     "babel-loader": "^8.2.5",
     "babel-plugin-macros": "^3.1.0",
     "compression-webpack-plugin": "^9.2.0",
+    "create-react-class": "^15.6.2",
     "css-loader": "^5.2.7",
     "css-minimizer-webpack-plugin": "^2.0.0",
     "mini-css-extract-plugin": "^1.6.2",
     "pnp-webpack-plugin": "^1.7.0",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",
+    "react_ujs": "file:.yalc/react_ujs",
     "shakapacker": "^6.4.1",
     "style-loader": "^3.3.1",
     "terser-webpack-plugin": "^5.3.3",
@@ -25,8 +27,12 @@
     "webpack-sources": "^3.2.3"
   },
   "devDependencies": {
+    "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
     "@pmmmwh/react-refresh-webpack-plugin": "^0.5.7",
     "react-refresh": "^0.13.0",
     "webpack-dev-server": "^4.9.2"
+  },
+  "scripts": {
+    "yalc-postinstall": "yalc link react_ujs"
   }
 }