Tweak option naming

Author: gaearon

README.md

@@ -6,11 +6,11 @@ APIs.
 
 ### Usage
 `npx react-codemod <transform> <path> [...options]`
-   * `transform` - name of transform, see available transforms below. 
+   * `transform` - name of transform, see available transforms below.
    * `path` - files or directory to transform
    * use the `--dry` option for a dry-run and use `--print` to print the output for comparison
 
-This will start an interactive wizard, and then run the specified transform. 
+This will start an interactive wizard, and then run the specified transform.
 
 ### Included Transforms
 
@@ -55,10 +55,10 @@ npx react-codemod manual-bind-to-arrow <path>
 Converts ES6 classes that only have a render method, only have safe properties
 (statics and props), and do not have refs to Functional Components.
 
-The wizard will ask for 2 options - 
+The wizard will ask for 2 options -
 
-* **Use arrow functions?**: converts to arrow function. Converts to `function` by default.  
-* **Destructure props?**: will destructure props in the argument where it is safe to do so.  
+* **Use arrow functions?**: converts to arrow function. Converts to `function` by default.
+* **Destructure props?**: will destructure props in the argument where it is safe to do so.
 
 ```sh
 npx react-codemod pure-component <path>
@@ -118,7 +118,7 @@ npx react-codemod react-to-react-dom <path>
 
 #### `React-DOM-to-react-dom-factories`
 
-Converts calls like `React.DOM.div(...)` to `React.createElement('div', ...)`. 
+Converts calls like `React.DOM.div(...)` to `React.createElement('div', ...)`.
 
 ```sh
 npx react-codemod React-DOM-to-react-dom-factories <path>
@@ -145,11 +145,11 @@ npx react-codemod sort-comp <path>
 
 #### `update-react-imports`
 
-[As of Babel 7.9.0](https://babeljs.io/blog/2020/03/16/7.9.0#a-new-jsx-transform-11154-https-githubcom-babel-babel-pull-11154), when using `runtime: automatic` in `@babel/preset-react` or `@babel/plugin-transform-react-jsx`, you will not need to explicitly import React for compiling jsx. This codemod removes the redundant import statements. It also converts  (`import React from 'react'`) to named imports (`import * as React from 'react'`).
+[As of Babel 7.9.0](https://babeljs.io/blog/2020/03/16/7.9.0#a-new-jsx-transform-11154-https-githubcom-babel-babel-pull-11154), when using `runtime: automatic` in `@babel/preset-react` or `@babel/plugin-transform-react-jsx`, you will not need to explicitly import React for compiling jsx. This codemod removes the redundant import statements. It also converts default imports (`import React from 'react'`) to named imports (e.g. `import { useState } from 'react'`).
 
-The wizard will ask for 1 option - 
+The wizard will ask for 1 option -
 
-* **Destructure named imports?**: Destructures named imports (import * as React from 'react') as well as default imports. Does not do this by default.  
+* **Destructure namespace imports as well?**: If chosen, *namespace* imports like `import * as React` will *also* be converted. By default, it's false, so only default imports (`import React`) are converted.
 
 ```sh
 npx react-codemod update-react-imports <path>
@@ -207,7 +207,7 @@ To pass more options directly to jscodeshift, use `--jscodeshift="..."`. For exa
 npx react-codemod --jscodeshift="--run-in-band --verbose=2"
 ```
 
-See all available options [here](https://github.com/facebook/jscodeshift#usage-cli). 
+See all available options [here](https://github.com/facebook/jscodeshift#usage-cli).
 
 ### Recast Options
 
@@ -220,7 +220,7 @@ npx react-codemod <transform> <path> --jscodeshift="--printOptions='{\"quote\":\
 
 #### `explicit-require=false`
 
-If you're not explicitly importing React in your files (eg: if you're loading React with a script tag), you should add `--explicit-require=false`. 
+If you're not explicitly importing React in your files (eg: if you're loading React with a script tag), you should add `--explicit-require=false`.
 
 ### Support and Contributing
 

bin/cli.js

@@ -2,7 +2,7 @@
  * Copyright 2015-present, Facebook, Inc.
  *
  * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree. 
+ * LICENSE file in the root directory of this source tree.
  *
  */
 
@@ -72,7 +72,7 @@ function runTransform({ files, flags, parser, transformer, answers }) {
   args.push('--ignore-pattern=**/node_modules/**');
 
   args.push('--parser', parser);
-  
+
   if (parser === 'tsx') {
     args.push('--extensions=tsx,ts,jsx,js');
   } else {
@@ -100,8 +100,8 @@ function runTransform({ files, flags, parser, transformer, answers }) {
   }
 
   if (transformer === 'update-react-imports') {
-    if (answers.destructureNamedImports) {
-      args.push('--destructureNamedImports=true');
+    if (answers.destructureNamespaceImports) {
+      args.push('--destructureNamespaceImports=true');
     }
   }
 
@@ -226,7 +226,7 @@ function run() {
     Usage
       $ npx react-codemod <transform> <path> <...options>
 
-        transform    One of the choices from https://github.com/reactjs/react-codemod 
+        transform    One of the choices from https://github.com/reactjs/react-codemod
         path         Files or directory to transform. Can be a glob like src/**.test.js
 
     Options
@@ -371,14 +371,14 @@ function run() {
       },
       {
         type: 'confirm',
-        name: 'destructureNamedImports',
+        name: 'destructureNamespaceImports',
         when: answers => {
           return (
             cli.input[0] === 'update-react-imports' ||
             answers.transformer === 'update-react-imports'
           );
         },
-        message: 'Destructure named imports?',
+        message: 'Destructure namespace imports (import *) too?',
         default: false
       }
     ])

transforms/__tests__/update-react-imports-test.js

@@ -88,7 +88,7 @@ destructureNamedImportTests.forEach((test) => {
   defineTest(
     __dirname,
     'update-react-imports',
-    {destructureNamedImports: true},
+    {destructureNamespaceImports: true},
     `update-react-imports/${test}`
   );
 });

transforms/update-react-imports.js

@@ -10,7 +10,7 @@ module.exports = function(file, api, options) {
   const j = api.jscodeshift;
   const printOptions = options.printOptions || {};
   const root = j(file.source);
-  const destructureNamedImports = options.destructureNamedImports;
+  const destructureNamespaceImports = options.destructureNamespaceImports;
 
   // https://github.com/facebook/jscodeshift/blob/master/recipes/retain-first-comment.md
   function getFirstNode() {
@@ -98,7 +98,7 @@ module.exports = function(file, api, options) {
   const reactIdentifiers = {};
   const reactTypeIdentifiers = {};
   let canDestructureReactVariable = false;
-  if (isReactImportUsed && (isDefaultImport || destructureNamedImports)) {
+  if (isReactImportUsed && (isDefaultImport || destructureNamespaceImports)) {
     // Checks to see if the react variable is used itself (rather than used to access its properties)
     canDestructureReactVariable =
       root