updated constructor args (only use props/context when needed)

Author: Keyan Zhang

transforms/__testfixtures__/class-pure-mixin1.output.js

@@ -1,8 +1,8 @@
 var React = require('React');
 
 class ComponentWithOnlyPureRenderMixin extends React.PureComponent {
-  constructor(props, context) {
-    super(props, context);
+  constructor(props) {
+    super(props);
 
     this.state = {
       counter: props.initialNumber + 1,

transforms/__testfixtures__/class-pure-mixin2.output.js

@@ -2,8 +2,8 @@ import React from 'React';
 import dontPruneMe from 'foobar';
 
 class ComponentWithOnlyPureRenderMixin extends React.PureComponent {
-  constructor(props, context) {
-    super(props, context);
+  constructor(props) {
+    super(props);
 
     this.state = {
       counter: props.initialNumber + 1,

transforms/__testfixtures__/class-test2.input.js

@@ -23,6 +23,24 @@ var ComponentWithNonSimpleInitialState = React.createClass({
   },
 });
 
+var ComponentWithBothPropsAndContextAccess = React.createClass({
+  contextTypes: {
+    name: React.PropTypes.string,
+  },
+
+  getInitialState: function() {
+    return {
+      foo: this.props.foo,
+    };
+  },
+
+  render: function() {
+    return (
+      <div>{this.context.name}</div>
+    );
+  },
+});
+
 // Comment
 module.exports = React.createClass({
   propTypes: {

transforms/__testfixtures__/class-test2.output.js

@@ -8,8 +8,8 @@ class ComponentWithNonSimpleInitialState extends React.Component {
   static iDontKnowWhyYouNeedThis = true; // but comment it
   static foo = 'bar';
 
-  constructor(props, context) {
-    super(props, context);
+  constructor(props) {
+    super(props);
 
     this.state = {
       counter: props.initialNumber + 1,
@@ -23,6 +23,26 @@ class ComponentWithNonSimpleInitialState extends React.Component {
   }
 }
 
+class ComponentWithBothPropsAndContextAccess extends React.Component {
+  static contextTypes = {
+    name: React.PropTypes.string,
+  };
+
+  constructor(props, context) {
+    super(props, context);
+
+    this.state = {
+      foo: props.foo,
+    };
+  }
+
+  render() {
+    return (
+      <div>{this.context.name}</div>
+    );
+  }
+}
+
 // Comment
 module.exports = class extends React.Component {
   static propTypes = {
@@ -33,8 +53,8 @@ module.exports = class extends React.Component {
     foo: 12,
   };
 
-  constructor(props, context) {
-    super(props, context);
+  constructor() {
+    super();
     // non-simple getInitialState
     var data = 'bar';
 

transforms/__testfixtures__/class.output.js

@@ -9,8 +9,8 @@ var Image = require('Image.react');
  * Multiline
  */
 class MyComponent extends React.Component {
-  constructor(props, context) {
-    super(props, context);
+  constructor(props) {
+    super(props);
     var x = props.foo;
 
     this.state = {
@@ -54,8 +54,8 @@ class MyComponent3 extends React.Component {
     };
   }();
 
-  constructor(props, context) {
-    super(props, context);
+  constructor(props) {
+    super(props);
     props.foo();
 
     this.state = {

transforms/class.js

@@ -307,26 +307,32 @@ module.exports = (file, api, options) => {
       false
     ), getInitialState);
 
-  const createConstructorArgs = () => {
-    return [j.identifier('props'), j.identifier('context')];
+  const createConstructorArgs = (hasPropsAccess, hasContextAccess) => {
+    if (hasContextAccess) {
+      return [j.identifier('props'), j.identifier('context')];
+    } else if (hasPropsAccess) {
+      return [j.identifier('props')];
+    }
+    return [];
   };
 
-  const createConstructor = getInitialState => {
-    updatePropsAccess(getInitialState);
+  const createConstructor = (getInitialState, hasContextAccess) => {
+    const hasPropsAccess = updatePropsAccess(getInitialState).size() > 0;
+    const constructorArgs = createConstructorArgs(hasPropsAccess, hasContextAccess);
 
     return [
       createMethodDefinition({
         key: j.identifier('constructor'),
         value: j.functionExpression(
           null,
-          createConstructorArgs(),
+          constructorArgs,
           j.blockStatement(
             [].concat(
               [
                 j.expressionStatement(
                   j.callExpression(
                     j.identifier('super'),
-                    [j.identifier('props'), j.identifier('context')]
+                    constructorArgs
                   )
                 ),
               ],
@@ -387,13 +393,15 @@ module.exports = (file, api, options) => {
   ) => {
     let maybeConstructor = [];
     const initialStateProperty = [];
-
+    const hasContextAccess = !!staticProperties.find((prop) =>
+      prop.key.name === 'contextTypes'
+    );
     if (isInitialStateLiftable(getInitialState)) {
       if (getInitialState) {
         initialStateProperty.push(convertInitialStateToClassProperty(getInitialState));
       }
     } else {
-      maybeConstructor = createConstructor(getInitialState);
+      maybeConstructor = createConstructor(getInitialState, hasContextAccess);
     }
 
     const propertiesAndMethods = rawProperties.map(prop => {