add dirty flag, update tests

Author: DmytroHryshyn

transforms/__testfixtures__/remove-context-provider/no-provider.output.js

@@ -1,9 +0,0 @@
-function App() {
-  const [theme, setTheme] = useState('light');
-
-  return (
-    <Context value={theme}>
-    <Page />
-    </Context>
-  );
-}

transforms/__testfixtures__/remove-context-provider/typescript/no-provider.output.js

@@ -1,9 +0,0 @@
-function App({ url }: { url: string }) {
-  const [theme, setTheme] = useState<'light' | 'dark'>('light');
-
-  return (
-    <Context value={theme}>
-      <Page />
-    </Context>
-  );
-}

transforms/__testfixtures__/use-context-hook/any-use-context.output.js

@@ -1 +0,0 @@
-const theme = trpc.useContext();

transforms/__testfixtures__/use-context-hook/typescript/any-use-context.output.js

@@ -1,8 +0,0 @@
-function Component({
-  appUrl,
-}: {
-  appUrl: string;
-}) {
-  const theme = trpc.useContext();
-  return <div />;
-};

transforms/remove-context-provider.ts

@@ -7,6 +7,8 @@ export default function transform(
   const j = api.jscodeshift;
   const root = j(file.source);
 
+  let isDirty = false;
+
   root.findJSXElements().forEach((elementPath) => {
     const { value } = elementPath;
     const elements = [value.openingElement, value.closingElement];
@@ -29,9 +31,10 @@ export default function transform(
         propertyName === 'Provider'
       ) {
         element.name = element.name.object;
+        isDirty = true;
       }
     });
   });
 
-  return root.toSource();
-};
+  return isDirty ? root.toSource() : undefined;
+}

transforms/remove-forward-ref.ts

@@ -97,7 +97,7 @@ export default function transform(file: FileInfo, api: API) {
 
   const root = j(file.source);
 
-  let dirtyFlag = false;
+  let isDirty = false;
 
   root
     .find(j.CallExpression, {
@@ -148,6 +148,8 @@ export default function transform(file: FileInfo, api: API) {
             value: j.identifier(refArgName),
           }),
         );
+
+        isDirty = true;
       }
 
       // if props arg is Identifier, push ref variable declaration to the function body
@@ -157,6 +159,8 @@ export default function transform(file: FileInfo, api: API) {
           refArg.name,
           propsArg.name,
         );
+
+        isDirty = true;
       }
 
       /**
@@ -175,6 +179,7 @@ export default function transform(file: FileInfo, api: API) {
             propsArgTypeReference,
             refArgTypeReference,
           );
+        isDirty = true;
       }
 
       /**
@@ -198,17 +203,18 @@ export default function transform(file: FileInfo, api: API) {
         ) {
           renderFunction.params[0].typeAnnotation =
             buildPropsAndRefIntersectionTypeAnnotation(j, propType, refType);
+
+          isDirty = true;
         }
       }
 
-      dirtyFlag = true;
       return renderFunction;
     });
 
   /**
    * handle import
    */
-  if (dirtyFlag) {
+  if (isDirty) {
     root
       .find(j.ImportDeclaration, {
         source: {
@@ -222,24 +228,19 @@ export default function transform(file: FileInfo, api: API) {
           return;
         }
 
-        if (specifiers === undefined) {
-          return;
-        }
+        const specifiersWithoutForwardRef =
+          specifiers?.filter(
+            (s) =>
+              j.ImportSpecifier.check(s) && s.imported.name !== 'forwardRef',
+          ) ?? [];
 
-        const forwardRefImportSpecifierIndex = specifiers.findIndex(
-          (s) => j.ImportSpecifier.check(s) && s.imported.name === 'forwardRef',
-        );
+        if (specifiersWithoutForwardRef.length === 0) {
+          j(importDeclarationPath).remove();
+        }
 
-        specifiers.splice(forwardRefImportSpecifierIndex, 1);
-      })
-      .filter((importDeclarationPath) => {
-        const { specifiers } = importDeclarationPath.node;
-        // remove the import if there are no more specifiers left after removing forwardRef
-        return specifiers === undefined || specifiers.length === 0;
-      })
-      .remove();
+        importDeclarationPath.node.specifiers = specifiersWithoutForwardRef;
+      });
   }
 
-  return root.toSource();
+  return isDirty ? root.toSource() : undefined;
 }
-

transforms/remove-memoization-hooks.ts

@@ -7,19 +7,22 @@ export default function transform(
   const j = api.jscodeshift;
   const root = j(file.source);
 
+  let isDirty = false;
+
   const hooksToRemove = ['useMemo', 'useCallback', 'memo'];
 
   root.find(j.ImportDeclaration).forEach((path) => {
     if (path.node.specifiers?.length === 0) {
       return;
     }
 
-    const specifiers = path.node.specifiers?.filter((specifier) => {
-      if (specifier.type === 'ImportSpecifier') {
-        return !hooksToRemove.includes(specifier.imported.name);
-      }
-      return specifier;
-    }) ?? [];
+    const specifiers =
+      path.node.specifiers?.filter((specifier) => {
+        if (specifier.type === 'ImportSpecifier') {
+          return !hooksToRemove.includes(specifier.imported.name);
+        }
+        return specifier;
+      }) ?? [];
 
     if (specifiers.length === 0) {
       j(path).remove();
@@ -36,7 +39,10 @@ export default function transform(
           name: hook,
         },
       })
-      .replaceWith((path) => path.value.arguments[0]);
+      .replaceWith((path) => {
+        isDirty = true;
+        return path.value.arguments[0];
+      });
   });
 
   hooksToRemove.forEach((hook) => {
@@ -48,8 +54,11 @@ export default function transform(
           property: { name: hook },
         },
       })
-      .replaceWith((path) => path.value.arguments[0]);
+      .replaceWith((path) => {
+        isDirty = true;
+        return path.value.arguments[0];
+      });
   });
 
-  return root.toSource();
+  return isDirty ? root.toSource() : undefined;
 }

transforms/use-context-hook.ts

@@ -8,15 +8,18 @@ export default function transform(
   const j = api.jscodeshift;
   const root = j(file.source);
 
+  let isDirty = false;
+
   // Get default import from react
-  const defaultReactImport = root
-    .find(j.ImportDeclaration, {
-      source: { value: 'react' },
-      specifiers: [{ type: 'ImportDefaultSpecifier' }],
-    })
-    .paths()
-    .at(0)
-    ?.node.specifiers?.at(0)?.local?.name ?? 'React';
+  const defaultReactImport =
+    root
+      .find(j.ImportDeclaration, {
+        source: { value: 'react' },
+        specifiers: [{ type: 'ImportDefaultSpecifier' }],
+      })
+      .paths()
+      .at(0)
+      ?.node.specifiers?.at(0)?.local?.name ?? 'React';
 
   // For usages like `import React from 'react'; React.useContext(ThemeContext)`
   root
@@ -32,7 +35,8 @@ export default function transform(
 
       const newIdentifier = j.identifier.from({ name: 'use' });
 
-			identifierPath?.replace(newIdentifier);
+      identifierPath?.replace(newIdentifier);
+      isDirty = true;
     });
 
   // Get useContext import name
@@ -60,9 +64,11 @@ export default function transform(
         const newIdentifier = j.identifier.from({ name: 'use' });
 
         path.replace(newIdentifier);
+
+        isDirty = true;
       }
     });
   }
 
-  return root.toSource();
+  return isDirty ? root.toSource() : undefined;
 }