|
| 1 | +## April 21 ([discuss](https://github.com/reactjs/core-notes/pull/6)) |
| 2 | + |
| 3 | +### Attendees |
| 4 | + |
| 5 | +* [Ben](https://twitter.com/soprano) (React) |
| 6 | +* [Dan](https://twitter.com/dan_abramov) (React) |
| 7 | +* [Jim](http://github.com/jimfb) (React) |
| 8 | +* [Paul](https://twitter.com/zpao) (React) |
| 9 | +* [Sebastian](https://twitter.com/sebmarkbage) (React) |
| 10 | +* [Shayne](https://github.com/shayne) (React Native) |
| 11 | +* [Tom](https://twitter.com/tomocchino) (React) |
| 12 | + |
| 13 | +### 15.0 Post Mortem |
| 14 | + |
| 15 | +#### Release was pretty rocky |
| 16 | +* We didn’t have a cohesive enough story around what was to be included in the release. |
| 17 | +* Now that we have more dependants (RN, many teams internally and externally) it’s becoming an issue. |
| 18 | +* Examples of changes that should we should have planned better: |
| 19 | + * [SVG attributes were passed through without a whitelist in RC1](https://github.com/facebook/react/pull/5714), then [we reverted this in RC2](https://github.com/zpao/react/commit/08fa7fe50707d4c7fe06861e0875b3fab00ea048). |
| 20 | + * We [switched to using attributes](https://github.com/facebook/react/pull/1510) by default but haven’t tested this as thoroughly as we should have, and it caused a few regressions, plus later it turned out that we didn’t all agree on this change ([Sebastian](https://twitter.com/sebmarkbage) was out of the loop). |
| 21 | +* Our default in the past has been to just work on everything individually. |
| 22 | + * [Ben](https://twitter.com/soprano) created a special GitHub group so that we can auto-subscribe all of us to some big picture issues. |
| 23 | +* We should have shipped an RC3. |
| 24 | + * But why did we get to RC2? |
| 25 | + * Having browser tests ([Jim](https://github.com/jimfb)) and planning releases ([Paul](https://twitter.com/zpao)) more thoroughly should fix this. |
| 26 | +* We should make the release process easier. |
| 27 | + * Right now there’s too much manual work involved. |
| 28 | + * If it was just one command, maybe we would have been more open to releasing RC3. |
| 29 | + |
| 30 | +### Releasing 15.0.2 |
| 31 | + |
| 32 | +* Either this Friday or early next week. |
| 33 | +* We merged some changes to [bring the `react-native-renderer` into the React repo](https://github.com/facebook/react/pull/6338) so we can change React internals more freely without breaking RN. |
| 34 | +* What else should get into 15.0.2? |
| 35 | + * [Fix for the `optgroup`s](https://github.com/facebook/react/pull/6442). |
| 36 | + * [CSS warning fix](https://github.com/facebook/react/pull/6458). |
| 37 | + * [TestUtils fix](https://github.com/facebook/react/pull/6362). |
| 38 | +* Right now we just run master on Facebook. |
| 39 | +* In six months, master and 15.x can diverge significantly. |
| 40 | +* We need to figure out a better story around syncing React with: |
| 41 | + * The Facebook website. |
| 42 | + * React Native. |
| 43 | +* [Paul](https://twitter.com/zpao) will write up how we’re going to do releases moving forward. |
| 44 | + |
| 45 | +### Universal Components |
| 46 | + |
| 47 | +* [Nicolas](https://github.com/necolas) from Twitter created [React Native Web](https://github.com/necolas/react-native-web). |
| 48 | +* [Leland](https://github.com/lelandrichardson) from Airbnb maintains [a fork](https://github.com/lelandrichardson/react-native-web). |
| 49 | +* It is not clear how to create universal components. |
| 50 | +* For example, if you depend on `View` from `react-native`, you pull in the whole `react-native`. |
| 51 | +* How do you create a component that is renderable both in React Native and React Native Web? |
| 52 | + * Some registration system? |
| 53 | + * Injectable components? |
| 54 | + * Strings? |
| 55 | +* No conclusion, lots to think about. |
| 56 | + |
| 57 | +### Adding Flow to React |
| 58 | + |
| 59 | +* Flow has helped engineers at Facebook immensely, and it might help us here: |
| 60 | + * WeЪd like to be more confident in the changes we want to make. |
| 61 | + * Might help newcomers be more comfortable making changes in the codebase. |
| 62 | + * [Ben](https://twitter.com/soprano) might experiment with adding it in some places, but we might want to hold off. |
| 63 | +* [Sebastian](https://twitter.com/sebmarkbage)’s concerns: |
| 64 | + * [The work on incremental reconciler](https://github.com/facebook/react/issues/6170) is going to be very invasive. |
| 65 | + * Forcing addition of Flow in places where it’s very hard to type should be a non-goal as there’s a lot of meta-programming. |
| 66 | + |
| 67 | +### Who’s Working on What |
| 68 | + |
| 69 | +* [Ben](https://twitter.com/soprano): Working on some education material for React that could end up in the docs. |
| 70 | +* [Dan](https://twitter.com/dan_abramov): After a chat with Sebastian, [submitted another PR](https://github.com/facebook/react/pull/6549) for the future ReactPerf and DevTools revamp. |
| 71 | +* [Jim](http://github.com/jimfb): Mostly still fixing regressions. |
| 72 | +* [Paul](https://twitter.com/zpao): [Flat bundles](https://github.com/facebook/react/issues/6351), modernizing our build process, thinking about the new release process. |
| 73 | +* [Sebastian](https://twitter.com/sebmarkbage): Bug fixes to make React Native to work with React 15. |
| 74 | +* [Shayne](https://github.com/shayne): React Native relies on npm, so we need a better way of consuming npm modules internally at Facebook. |
| 75 | + |
| 76 | + |
| 77 | +------------ |
| 78 | + |
| 79 | +Please feel free to discuss these notes in the [corresponding pull request](https://github.com/reactjs/core-notes/pull/6). |
0 commit comments