diff --git a/docs/source/about/changelog.rst b/docs/source/about/changelog.rst index 7fd722c5d..1f9e595c3 100644 --- a/docs/source/about/changelog.rst +++ b/docs/source/about/changelog.rst @@ -23,7 +23,13 @@ more info, see the :ref:`Contributor Guide `. Unreleased ---------- -No changes. +**Added** + +- :pull:`123` - ``asgiref`` as a dependency + +**Changed** + +- :pull:`123` - set default timeout on playwright page for testing v0.39.0 diff --git a/requirements/pkg-deps.txt b/requirements/pkg-deps.txt index 6e970f4c2..f13b33bf9 100644 --- a/requirements/pkg-deps.txt +++ b/requirements/pkg-deps.txt @@ -5,3 +5,4 @@ jsonpatch >=1.32 fastjsonschema >=2.14.5 requests >=2 colorlog >=6 +asgiref >=3 diff --git a/src/idom/config.py b/src/idom/config.py index a13a2e26f..dec2cb958 100644 --- a/src/idom/config.py +++ b/src/idom/config.py @@ -80,7 +80,8 @@ IDOM_TESTING_DEFAULT_TIMEOUT = _Option( "IDOM_TESTING_DEFAULT_TIMEOUT", - 3.0, + 5.0, mutable=False, validator=float, ) +"""A default timeout for testing utilities in IDOM""" diff --git a/src/idom/testing/display.py b/src/idom/testing/display.py index 30151a7a3..0715f7a51 100644 --- a/src/idom/testing/display.py +++ b/src/idom/testing/display.py @@ -7,6 +7,7 @@ from playwright.async_api import Browser, BrowserContext, Page, async_playwright from idom import html +from idom.config import IDOM_TESTING_DEFAULT_TIMEOUT from idom.types import RootComponentConstructor from .backend import BackendFixture @@ -57,6 +58,8 @@ async def __aenter__(self) -> DisplayFixture: browser = self._browser self.page = await browser.new_page() + self.page.set_default_timeout(IDOM_TESTING_DEFAULT_TIMEOUT.current * 1000) + if not hasattr(self, "backend"): self.backend = BackendFixture() await es.enter_async_context(self.backend)