From 19517b5169275c87e617b4ec2e4977f0aafc413b Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Thu, 24 Feb 2022 08:30:56 -0800 Subject: [PATCH 1/2] reset schedule_render_later flag after triggering --- src/idom/core/hooks.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/idom/core/hooks.py b/src/idom/core/hooks.py index d0717162e..c19b9e547 100644 --- a/src/idom/core/hooks.py +++ b/src/idom/core/hooks.py @@ -690,6 +690,7 @@ def affect_layout_did_render(self) -> None: if self._schedule_render_later: self._schedule_render() + self._schedule_render_later = False def affect_component_will_unmount(self) -> None: """The component is about to be removed from the layout""" From 4a5ecdfc68077e665626d8fc3329de2edc42f696 Mon Sep 17 00:00:00 2001 From: rmorshea Date: Thu, 24 Feb 2022 08:42:52 -0800 Subject: [PATCH 2/2] fix typing issue with latest ver of selenium --- src/idom/testing.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/idom/testing.py b/src/idom/testing.py index f9581b45f..ad7a9bac1 100644 --- a/src/idom/testing.py +++ b/src/idom/testing.py @@ -25,7 +25,9 @@ from uuid import uuid4 from weakref import ref -from selenium.webdriver import Chrome +from selenium.webdriver.chrome.options import Options as ChromeOptions +from selenium.webdriver.chrome.webdriver import WebDriver as Chrome +from selenium.webdriver.common.options import BaseOptions from selenium.webdriver.remote.webdriver import WebDriver from idom.config import IDOM_WEB_MODULES_DIR @@ -47,7 +49,7 @@ def create_simple_selenium_web_driver( driver_type: Type[WebDriver] = Chrome, - driver_options: Optional[Any] = None, + driver_options: BaseOptions = ChromeOptions(), implicit_wait_timeout: float = 10.0, page_load_timeout: float = 5.0, window_size: Tuple[int, int] = (1080, 800),