Skip to content

Commit b1df8a6

Browse files
committed
fix mypy issues
1 parent 94681b6 commit b1df8a6

File tree

3 files changed

+16
-23
lines changed

3 files changed

+16
-23
lines changed

src/idom/server/flask.py

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import idom
2626
from idom.config import IDOM_CLIENT_BUILD_DIR, IDOM_DEBUG_MODE
2727
from idom.core.component import AbstractComponent, ComponentConstructor
28-
from idom.core.dispatcher import RecvCoroutine, SendCoroutine, dispatch_single_view
28+
from idom.core.dispatcher import dispatch_single_view
2929
from idom.core.layout import LayoutEvent, LayoutUpdate
3030

3131
from .utils import threaded, wait_on_event
@@ -159,22 +159,17 @@ def _setup_single_view_dispatcher_route(
159159

160160
@sockets.route(_join_url_paths(config["url_prefix"], "/stream")) # type: ignore
161161
def model_stream(ws: WebSocket) -> None:
162-
send, recv = _make_send_recv_callbacks(ws)
163-
dispatch_single_view_in_thread(constructor(**_get_query_params(ws)), send, recv)
164-
162+
def send(value: Any) -> None:
163+
ws.send(json.dumps(value))
165164

166-
def _make_send_recv_callbacks(ws: WebSocket) -> Tuple[SendCoroutine, RecvCoroutine]:
167-
def send(value: Any) -> None:
168-
ws.send(json.dumps(value))
165+
def recv() -> Optional[LayoutEvent]:
166+
event = ws.receive()
167+
if event is not None:
168+
return LayoutEvent(**json.loads(event))
169+
else:
170+
return None
169171

170-
def recv() -> Optional[LayoutEvent]:
171-
event = ws.receive()
172-
if event is not None:
173-
return LayoutEvent(**json.loads(event))
174-
else:
175-
return None
176-
177-
return send, recv
172+
dispatch_single_view_in_thread(constructor(**_get_query_params(ws)), send, recv)
178173

179174

180175
def _get_query_params(ws: WebSocket) -> Dict[str, Any]:

src/idom/server/tornado.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,11 @@ def _setup_common_routes(config: Config) -> _RouteHandlerSpecs:
137137
def _add_handler(
138138
app: Application, config: Config, handlers: _RouteHandlerSpecs
139139
) -> None:
140-
app.add_handlers(
141-
r".*",
142-
[
143-
(urljoin(config["url_prefix"], route_pattern),) + tuple(handler_info)
144-
for route_pattern, *handler_info in handlers
145-
],
146-
)
140+
prefixed_handlers: List[Any] = [
141+
(urljoin(config["url_prefix"], route_pattern),) + tuple(handler_info)
142+
for route_pattern, *handler_info in handlers
143+
]
144+
app.add_handlers(r".*", prefixed_handlers)
147145

148146

149147
def _setup_single_view_dispatcher_route(

src/idom/server/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def target() -> None:
3535
return cast(_Func, wrapper)
3636

3737

38-
def wait_on_event(description: str, event: Event, timeout: float) -> None:
38+
def wait_on_event(description: str, event: Event, timeout: Optional[float]) -> None:
3939
if not event.wait(timeout):
4040
raise TimeoutError(f"Did not {description} within {timeout} seconds")
4141

0 commit comments

Comments
 (0)