no need to be clever - just inherit

Author: rmorshea

src/py/reactpy/reactpy/_option.py

@@ -11,12 +11,6 @@
 UNDEFINED = cast(Any, object())
 
 
-def deprecate(option: Option[_O], message: str) -> Option[_O]:
-    option.__class__ = _DeprecatedOption
-    option._deprecation_message = message
-    return option
-
-
 class Option(Generic[_O]):
     """An option that can be set using an environment variable of the same name"""
 
@@ -138,7 +132,13 @@ def __repr__(self) -> str:
         return f"Option({self._name}={self.current!r})"
 
 
-class _DeprecatedOption(Option[_O]):  # nocov
+class DeprecatedOption(Option[_O]):
+    """An option that will warn when it is accessed"""
+
+    def __init__(self, *args: Any, message: str, **kwargs: Any) -> None:
+        super().__init__(*args, **kwargs)
+        self._deprecation_message = message
+
     @Option.current.getter  # type: ignore
     def current(self) -> _O:
         warn(self._deprecation_message, DeprecationWarning)

src/py/reactpy/tests/test__option.py

@@ -3,7 +3,7 @@
 
 import pytest
 
-from reactpy._option import Option, deprecate
+from reactpy._option import DeprecatedOption, Option
 
 
 def test_option_repr():
@@ -102,7 +102,7 @@ def test_option_subscribe():
 
 
 def test_deprecated_option():
-    opt = deprecate(Option("A_FAKE_OPTION", None), "is deprecated!")
+    opt = DeprecatedOption("A_FAKE_OPTION", None, message="is deprecated!")
 
     with pytest.warns(DeprecationWarning, match="is deprecated!"):
         assert opt.current is None