more fixes

Author: rmorshea

pyproject.toml

@@ -11,10 +11,16 @@ description = "Scripts for managing the ReactPy respository"
 detached = true
 dependencies = [
   "invoke",
+  # lint
   "black",
   "ruff",
   "toml",
+  "flake8",
+  "flake8-pyproject",
+  "reactpy-flake8 >=0.7",
+  # publish
   "semver >=2, <3",
+  "twine",
 ]
 
 [tool.hatch.envs.default.scripts]
@@ -33,6 +39,12 @@ test-docs = "invoke test-docs"
 target-version = ["py39"]
 line-length = 88
 
+# --- Flake8 ----------------------------------------------------------------------------
+
+[tool.flake8]
+select = ["RPY"]  # only need to check with reactpy-flake8
+exclude = ["**/node_modules/*", ".eggs/*", ".tox/*", "**/venv/*"]
+
 # --- Ruff -----------------------------------------------------------------------------
 
 [tool.ruff]

requirements/check-types.txt

@@ -93,18 +93,21 @@ dependencies = [
 ]
 [tool.hatch.envs.default.scripts]
 test = "playwright install && pytest {args:tests}"
-test-cov = "coverage run -m pytest {args:tests}"
+test-cov = "playwright install && coverage run -m pytest {args:tests}"
 cov-report = [
-  "- coverage combine",
+  # "- coverage combine",
   "coverage report",
 ]
 cov = [
   "test-cov",
   "cov-report",
 ]
 
+[tool.hatch.envs.default.env-vars]
+REACTPY_DEBUG_MODE="1"
+
 [tool.hatch.envs.lint]
-detached = true
+features = ["all"]
 dependencies = [
   "mypy>=1.0.0",
   "types-click",
@@ -149,25 +152,21 @@ warn_unused_ignores = true
 # --- Coverage -------------------------------------------------------------------------
 
 [tool.coverage.run]
-source_pkgs = ["reactpy", "tests"]
-branch = true
-parallel = true
+source_pkgs = ["reactpy"]
+branch = false
+parallel = false
 omit = [
   "reactpy/__init__.py",
 ]
 
-[tool.coverage.paths]
-reactpy = ["reactpy", "*/reactpy/reactpy"]
-tests = ["tests", "*/reactpy/tests"]
-
 [tool.coverage.report]
 fail_under = 100
 show_missing = true
 skip_covered = true
 sort = "Name"
 exclude_lines = [
-  "no cov",
-  '\.\.\.\$',
+  "no ?cov",
+  '\.\.\.',
   "if __name__ == .__main__.:",
   "if TYPE_CHECKING:",
 ]

requirements/make-release.txt

@@ -27,10 +27,10 @@ def create_development_app() -> Any:
     return _default_implementation().create_development_app()
 
 
-def Options(*args: Any, **kwargs: Any) -> NoReturn:
+def Options(*args: Any, **kwargs: Any) -> NoReturn:  # pragma: no cover
     """Create configuration options"""
     msg = "Default implementation has no options."
-    raise ValueError(msg)  # pragma: no cover
+    raise ValueError(msg)
 
 
 async def serve_development_app(

src/py/reactpy/pyproject.toml

@@ -5,13 +5,13 @@
 import os
 import re
 import sys
-import toml
 from dataclasses import dataclass
 from pathlib import Path
 from shutil import rmtree
 from typing import TYPE_CHECKING, Any, Callable
 
 import semver
+import toml
 from invoke import task
 from invoke.context import Context
 from invoke.exceptions import Exit
@@ -69,28 +69,45 @@ def __call__(
 @task
 def env(context: Context):
     """Install development environment"""
-    in_py(context, "pip install -e .", hide="out")
-    in_js(context, "npm ci", hide="out")
+    env_py(context)
+    env_js(context)
+
+
+@task
+def env_py(context: Context):
+    """Install Python development environment"""
     for py_proj in PY_PROJECTS:
         py_proj_toml = toml.load(py_proj / "pyproject.toml")
         hatch_default_env = py_proj_toml["tool"]["hatch"]["envs"].get("default", {})
+        hatch_default_features = hatch_default_env.get("features", [])
         hatch_default_deps = hatch_default_env.get("dependencies", [])
+        with context.cd(py_proj):
+            context.run(f"pip install '.[{','.join(hatch_default_features)}]'")
         context.run(f"pip install {' '.join(map(repr, hatch_default_deps))}")
 
 
+@task
+def env_js(context: Context):
+    """Install JS development environment"""
+    in_js(context, "npm ci", hide="out")
+
+
 @task
 def lint_py(context: Context, fix: bool = False):
     """Run linters and type checkers"""
     if fix:
-        context.run("black .")
         context.run("ruff --fix .")
     else:
         context.run("ruff .")
         context.run("black --check --diff .")
-    in_py(context, "hatch run lint:all")
+        in_py(
+            context,
+            f"flake8 --toml-config {ROOT / 'pyproject.toml'} .",
+            "hatch run lint:all",
+        )
 
 
-@task
+@task(pre=[env_js])
 def lint_js(context: Context, fix: bool = False):
     """Run linters and type checkers"""
     if fix:
@@ -106,13 +123,13 @@ def test_py(context: Context, no_cov: bool = False):
     in_py(context, f"hatch run {'test' if no_cov else 'cov'}")
 
 
-@task
+@task(pre=[env_js])
 def test_js(context: Context):
     """Run test suites"""
     in_js(context, "npm run check:tests")
 
 
-@task
+@task(pre=[env_py])
 def test_docs(context: Context):
     raise Exit("Not implemented")