fix: drop collation changes

According to Android docs, one needs to be consistent when using
NO_COLLATION flag with how database was created, so changing this during
runtime makes no sense and can lead to some unexpected errors/behaviors
(SQLite default collation rule is BINARY).

Author: Krzysztof Borowy

android/build.gradle

@@ -33,10 +33,6 @@ def useDedicatedExecutor = rootProject.hasProperty('AsyncStorage_dedicatedExecut
         ? rootProject.properties['AsyncStorage_dedicatedExecutor']
         : false
 
-def disableLocalizedCollators = rootProject.hasProperty('AsyncStorage_noLocalizedCollators')
-        ? rootProject.properties['AsyncStorage_noLocalizedCollators']
-        : false
-
 apply plugin: 'com.android.library'
 
 android {
@@ -47,7 +43,6 @@ android {
         targetSdkVersion safeExtGet('targetSdkVersion', 28)
         buildConfigField "Long", "AsyncStorage_db_size", "${dbSizeInMB}L"
         buildConfigField("boolean", "AsyncStorage_useDedicatedExecutor", "${useDedicatedExecutor}")
-        buildConfigField("boolean", "AsyncStorage_noLocalizedCollators", "${disableLocalizedCollators}")
     }
     lintOptions {
         abortOnError false

android/src/main/java/com/reactnativecommunity/asyncstorage/ReactDatabaseSupplier.java

@@ -7,15 +7,14 @@
 
 package com.reactnativecommunity.asyncstorage;
 
-import javax.annotation.Nullable;
-
 import android.content.Context;
 import android.database.sqlite.SQLiteDatabase;
 import android.database.sqlite.SQLiteException;
 import android.database.sqlite.SQLiteOpenHelper;
-
 import com.facebook.common.logging.FLog;
 import com.facebook.react.common.ReactConstants;
+import java.io.File;
+import javax.annotation.Nullable;
 
 /**
  * Database supplier of the database used by react native. This creates, opens and deletes the
@@ -44,7 +43,6 @@ public class ReactDatabaseSupplier extends SQLiteOpenHelper {
   private Context mContext;
   private @Nullable SQLiteDatabase mDb;
   private long mMaximumDatabaseSize =  BuildConfig.AsyncStorage_db_size * 1024L * 1024L;
-  private boolean disableLocalizedCollators = BuildConfig.AsyncStorage_noLocalizedCollators;
 
   private ReactDatabaseSupplier(Context context) {
     super(context, DATABASE_NAME, null, DATABASE_VERSION);
@@ -86,13 +84,7 @@ public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
         if (tries > 0) {
           deleteDatabase();
         }
-
-        if(disableLocalizedCollators) {
-          String dbPath = mContext.getDatabasePath(DATABASE_NAME).getPath();
-          mDb = SQLiteDatabase.openDatabase(dbPath, null, SQLiteDatabase.NO_LOCALIZED_COLLATORS | SQLiteDatabase.OPEN_READWRITE);
-        } else {
-          mDb = getWritableDatabase();
-        }
+        mDb = getWritableDatabase();
         break;
       } catch (SQLiteException e) {
         lastSQLiteException = e;
@@ -114,6 +106,11 @@ public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
     return true;
   }
 
+  private synchronized boolean isDbCreated(String path) {
+    File dbFile = new File(path);
+    return dbFile.exists();
+  }
+
   /**
    * Create and/or open the database.
    */

example/android/gradle.properties

@@ -22,7 +22,6 @@
 
 # Enable dedicated thread pool executor
 AsyncStorage_dedicatedExecutor=true
-AsyncStorage_noLocalizedCollators=true
 
 android.useAndroidX=true
 android.enableJetifier=true