Skip to content

Commit 8a1003f

Browse files
author
Krzysztof Borowy
committed
comments
1 parent c2b8056 commit 8a1003f

File tree

9 files changed

+20
-16
lines changed

9 files changed

+20
-16
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

.eslintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"extends": ["@react-native-community"],
33
"rules": {
4-
"no-console": 2
4+
"no-console": "error"
55
}
66
}

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,6 @@ DerivedData
2828
*.xcuserstate
2929
local.properties
3030
*.iml
31+
32+
#workspaces
33+
/packages/*/lib

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"devDependencies": {
99
"@react-native-community/eslint-config": "3.2.0",
1010
"eslint": "8.26.0",
11-
"prettier": "2.4.1",
11+
"prettier": "2.5.1",
1212
"typescript": "4.9.5"
1313
},
1414
"resolutions": {

packages/core/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/core/package.json

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22
"name": "@react-native-async-storage/core",
33
"version": "0.0.0",
44
"description": "Core API of Async Storage",
5-
"main": "lib/commonjs/index",
6-
"module": "lib/module/index",
5+
"source": "src/index.ts",
6+
"react-native": "src/index.ts",
77
"types": "lib/typescript/index.d.ts",
8-
"react-native": "src/index",
9-
"source": "src/index",
8+
"exports": {
9+
"import": "./lib/module/index.js",
10+
"require": "./lib/commonjs/index.js"
11+
},
1012
"files": [
1113
"src",
1214
"lib"

packages/default-storage-backend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
"eslint-plugin-wdio": "^8.8.7",
9191
"expo": "^48.0.0",
9292
"lodash": "^4.17.21",
93-
"prettier": "2.4.1",
93+
"prettier": "2.5.1",
9494
"react": "18.2.0",
9595
"react-dom": "^18.2.0",
9696
"react-native": "^0.71.0",

packages/default-storage-backend/src/helpers.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable no-console */
21
import type { ErrorLike } from './types';
32

43
export function checkValidArgs(keyValuePairs: unknown[], callback: unknown) {
@@ -29,6 +28,7 @@ export function checkValidInput(...input: unknown[]) {
2928
const [key, value] = input;
3029

3130
if (typeof key !== 'string') {
31+
// eslint-disable-next-line no-console
3232
console.warn(
3333
`[AsyncStorage] Using ${typeof key} type for key is not supported. This can lead to unexpected behavior/errors. Use string instead.\nKey passed: ${key}\n`
3434
);
@@ -40,6 +40,7 @@ export function checkValidInput(...input: unknown[]) {
4040
`[AsyncStorage] Passing null/undefined as value is not supported. If you want to remove value, Use .removeItem method instead.\nPassed value: ${value}\nPassed key: ${key}\n`
4141
);
4242
} else {
43+
// eslint-disable-next-line no-console
4344
console.warn(
4445
`[AsyncStorage] The value for key "${key}" is not a string. This can lead to unexpected behavior/errors. Consider stringifying it.\nPassed value: ${value}\nPassed key: ${key}\n`
4546
);

yarn.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5135,7 +5135,7 @@ __metadata:
51355135
expo: ^48.0.0
51365136
lodash: ^4.17.21
51375137
merge-options: ^3.0.4
5138-
prettier: 2.4.1
5138+
prettier: 2.5.1
51395139
react: 18.2.0
51405140
react-dom: ^18.2.0
51415141
react-native: ^0.71.0
@@ -5170,7 +5170,7 @@ __metadata:
51705170
dependencies:
51715171
"@react-native-community/eslint-config": 3.2.0
51725172
eslint: 8.26.0
5173-
prettier: 2.4.1
5173+
prettier: 2.5.1
51745174
typescript: 4.9.5
51755175
languageName: unknown
51765176
linkType: soft
@@ -20077,12 +20077,12 @@ __metadata:
2007720077
languageName: node
2007820078
linkType: hard
2007920079

20080-
"prettier@npm:2.4.1":
20081-
version: 2.4.1
20082-
resolution: "prettier@npm:2.4.1"
20080+
"prettier@npm:2.5.1":
20081+
version: 2.5.1
20082+
resolution: "prettier@npm:2.5.1"
2008320083
bin:
2008420084
prettier: bin-prettier.js
20085-
checksum: cc6830588b401b0d742862fe9c46bc9118204fb307c3abe0e49e95b35ed23629573807ffdf9cdd65289c252a0bb51fc0171437f6626ee36378dea80f0ee80b91
20085+
checksum: 21b9408476ea1c544b0e45d51ceb94a84789ff92095abb710942d780c862d0daebdb29972d47f6b4d0f7ebbfb0ffbf56cc2cfa3e3e9d1cca54864af185b15b66
2008620086
languageName: node
2008720087
linkType: hard
2008820088

0 commit comments

Comments
 (0)