fix: throw error on invalid value

Author: Krzysztof Borowy

android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStorageErrorUtil.java

@@ -30,11 +30,11 @@ public class AsyncStorageErrorUtil {
   }
 
   /* package */ static WritableMap getInvalidKeyError(@Nullable String key) {
-    return getError(key, "Invalid key");
+    return getError(key, "Invalid key - expected string.");
   }
 
   /* package */ static WritableMap getInvalidValueError(@Nullable String key) {
-    return getError(key, "Invalid Value");
+    return getError(key, "Invalid Value - expected string.");
   }
 
   /* package */ static WritableMap getDBError(@Nullable String key) {

android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStorageModule.java

@@ -218,23 +218,21 @@ protected void doInBackgroundGuarded(Void... params) {
           for (int idx=0; idx < keyValueArray.size(); idx++) {
             if (keyValueArray.getArray(idx).size() != 2) {
               error = AsyncStorageErrorUtil.getInvalidValueError(null);
-              return;
             }
             if (keyValueArray.getArray(idx).getString(0) == null) {
               error = AsyncStorageErrorUtil.getInvalidKeyError(null);
-              return;
             }
             if (keyValueArray.getArray(idx).getString(1) == null) {
               error = AsyncStorageErrorUtil.getInvalidValueError(null);
-              return;
             }
-
-            statement.clearBindings();
-            statement.bindString(1, keyValueArray.getArray(idx).getString(0));
-            statement.bindString(2, keyValueArray.getArray(idx).getString(1));
-            statement.execute();
+            if(error == null) {
+              statement.clearBindings();
+              statement.bindString(1, keyValueArray.getArray(idx).getString(0));
+              statement.bindString(2, keyValueArray.getArray(idx).getString(1));
+              statement.execute();
+              mReactDatabaseSupplier.get().setTransactionSuccessful();
+            }
           }
-          mReactDatabaseSupplier.get().setTransactionSuccessful();
         } catch (Exception e) {
           FLog.w(ReactConstants.TAG, e.getMessage(), e);
           error = AsyncStorageErrorUtil.getError(null, e.getMessage());

lib/AsyncStorage.js

@@ -53,7 +53,7 @@ type MultiRequest = {|
 |};
 
 function checkValueTypeNotString(value: any, usedKey: string) {
-  if (typeof value !== 'string') {
+  if (value && typeof value !== 'string') {
     console.warn(
       `[AsyncStorage] The value for key "${usedKey}" is not a string. This can lead to unexpected behavior/errors. Consider stringifying it.`,
     );