Skip to content

Commit c8c7768

Browse files
committed
fix: clear cache when users click clear icon
close ant-design/ant-design#6731
1 parent 051c09d commit c8c7768

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/Select.jsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ class Select extends Component {
138138
this.renderedTreeData = this.renderTreeData(nextProps);
139139
// Detecting whether the object of `onChange`'s argument is old ref.
140140
// Better to do a deep equal later.
141-
this._cacheTreeNodesStates = this._cacheTreeNodesStates !== 'no' &&
141+
this._cacheTreeNodesStates = !this._cacheTreeNodesStates &&
142142
this._savedValue &&
143143
nextProps.value === this._savedValue;
144144
if (this.props.treeData !== nextProps.treeData ||
@@ -375,7 +375,8 @@ class Select extends Component {
375375
return;
376376
}
377377
event.stopPropagation();
378-
this._cacheTreeNodesStates = 'no';
378+
this._cacheTreeNodesStates = false;
379+
this._checkedNodes = [];
379380
if (state.inputValue || state.value.length) {
380381
this.fireChange([]);
381382
this.setOpenState(false);
@@ -640,7 +641,7 @@ class Select extends Component {
640641
if (props.disabled) {
641642
return;
642643
}
643-
this._cacheTreeNodesStates = 'no';
644+
this._cacheTreeNodesStates = false;
644645
if (props.treeCheckable &&
645646
(props.showCheckedStrategy === SHOW_ALL || props.showCheckedStrategy === SHOW_PARENT)
646647
&& !(props.treeCheckStrictly || this.state.inputValue)) {

tests/__mocks__/rc-trigger.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const Trigger = require.requireActual('rc-trigger');
44

55
const render = Trigger.prototype.render;
66

7-
Trigger.prototype.render = function () {
7+
Trigger.prototype.render = function _render() {
88
const { popupVisible } = this.state;
99
return (
1010
<div id="TriggerContainer">

0 commit comments

Comments
 (0)