Skip to content

Commit 110668c

Browse files
authored
GH Actions: selectively use fail-fast with setup-php (#240)
* GH Actions: selectively use `fail-fast` with setup-php I've seen some recent build failures due to the `setup-php` action running into a rate limit and not downloading the required version of Composer. In the case of this action, that would make the test runs worthless. The `setup-php` action runner defaults to _showing_ these type errors in the logs, but not stopping the workflow run. So, specifically for those jobs where the Composer version is important, I'm adding the `fail-fast` option to `setup-php` to fail the build if the action runner ran into any errors. Ref: https://github.com/shivammathur/setup-php#fail-fast-optional * GH Actions: update PHP version for `composer-normalize` Looks like the `composer-normalize` package has dropped support for PHP < 8.0 as of version `2.29.0`. Refs: * https://github.com/ergebnis/composer-normalize/releases/tag/2.29.0 * ergebnis/composer-normalize#998 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
1 parent 83af392 commit 110668c

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- name: "Set up PHP"
2121
uses: "shivammathur/setup-php@v2"
2222
with:
23-
php-version: 7.4
23+
php-version: 8.1
2424
tools: composer-normalize
2525
coverage: none
2626
- name: "Run Composer normalize"
@@ -47,6 +47,8 @@ jobs:
4747
php-version: "latest"
4848
tools: "composer:${{ matrix.composer-version }}"
4949
coverage: "none"
50+
env:
51+
fail-fast: true
5052
- name: "Run expect tests"
5153
run: "composer test"
5254

@@ -122,6 +124,8 @@ jobs:
122124
php-version: "latest"
123125
tools: "composer:${{ matrix.composer-version }}"
124126
coverage: "none"
127+
env:
128+
fail-fast: true
125129

126130
- name: "Test: plain install"
127131
uses: ./
@@ -251,6 +255,8 @@ jobs:
251255
php-version: "latest"
252256
tools: "composer:${{ matrix.composer-version }}"
253257
coverage: "none"
258+
env:
259+
fail-fast: true
254260

255261
- name: "Test: plain install"
256262
uses: ./

0 commit comments

Comments
 (0)