malloc/free in nogvl setup/cleanup

Author: bvogelzang

ext/tiny_tds/client.c

@@ -178,11 +178,6 @@ static void rb_tinytds_client_reset_userdata(tinytds_client_userdata *userdata)
   userdata->dbcancel_sent = 0;
   userdata->nonblocking = 0;
   userdata->nonblocking_errors_length = 0;
-  if (userdata->nonblocking_errors_size) {
-    free(userdata->nonblocking_errors);
-  }
-  userdata->nonblocking_errors = malloc(ERRORS_STACK_INIT_SIZE * sizeof(tinytds_errordata));
-  userdata->nonblocking_errors_size = ERRORS_STACK_INIT_SIZE;
 }
 
 static void rb_tinytds_client_mark(void *ptr) {
@@ -201,9 +196,6 @@ static void rb_tinytds_client_free(void *ptr) {
     cwrap->closed = 1;
     cwrap->userdata->closed = 1;
   }
-  if (cwrap->userdata->nonblocking_errors_size) {
-    free(cwrap->userdata->nonblocking_errors);
-  }
   xfree(ptr);
 }
 

ext/tiny_tds/result.c

@@ -86,6 +86,9 @@ static void dbcancel_ubf(DBPROCESS *client) {
 static void nogvl_setup(DBPROCESS *client) {
   GET_CLIENT_USERDATA(client);
   userdata->nonblocking = 1;
+  userdata->nonblocking_errors_length = 0;
+  userdata->nonblocking_errors = malloc(ERRORS_STACK_INIT_SIZE * sizeof(tinytds_errordata));
+  userdata->nonblocking_errors_size = ERRORS_STACK_INIT_SIZE;
 }
 
 static void nogvl_cleanup(DBPROCESS *client) {
@@ -108,7 +111,9 @@ static void nogvl_cleanup(DBPROCESS *client) {
     );
   }
 
+  free(userdata->nonblocking_errors);
   userdata->nonblocking_errors_length = 0;
+  userdata->nonblocking_errors_size = 0;
 }
 
 static RETCODE nogvl_dbsqlok(DBPROCESS *client) {