Test wrapped error.

Author: metaskills

lib/lambdakiq/adapter.rb

@@ -8,7 +8,6 @@ def enqueue(job, options = {})
       end
 
       def enqueue_at(job, timestamp)
-        puts "DELAY: #{delay_seconds(timestamp)}"
         enqueue job, delay_seconds: delay_seconds(timestamp)
       end
 

test/cases/job_test.rb

@@ -2,15 +2,20 @@
 
 class JobTest < LambdakiqSpec
   it 'must change message visibility to next value for failed jobs' do
-    stub_get_queue_attributes maxReceiveCount: 8
     event = event_basic attributes: { ApproximateReceiveCount: '7' }, job_class: 'TestHelper::Jobs::ErrorJob'
     expect(->{ Lambdakiq::Job.handler(event) }).must_raise 'HELL'
     expect(change_message_visibility).must_be :present?
     expect(change_message_visibility_params[:visibility_timeout]).must_equal 1416
   end
 
+  it 'wraps returned errors with no backtrace which avoids excessive/duplicate cloudwatch logging' do
+    event = event_basic job_class: 'TestHelper::Jobs::ErrorJob'
+    error = expect(->{ Lambdakiq::Job.handler(event) }).must_raise 'HELL'
+    expect(error.class.name).must_equal 'Lambdakiq::JobError'
+    expect(error.backtrace).must_equal []
+  end
+
   it 'must delete message for failed jobs at the end of the queue/message max receive count' do
-    stub_get_queue_attributes maxReceiveCount: 8
     event = event_basic attributes: { ApproximateReceiveCount: '8' }, job_class: 'TestHelper::Jobs::ErrorJob'
     Lambdakiq::Job.handler(event)
     expect(delete_message).must_be :present?

test/cases/queue_test.rb

@@ -2,7 +2,6 @@
 
 class QueueTest < LambdakiqSpec
   it '#max_receive_count' do
-    stub_get_queue_attributes maxReceiveCount: 8
     queue = Lambdakiq.client.queues[queue_name]
     expect(queue.max_receive_count).must_equal 8
   end

test/test_helper.rb

@@ -3,6 +3,7 @@
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
 require 'bundler/setup'
 Bundler.require :default, :development, :test
+require 'rails'
 require 'aws-sdk-sqs'
 require 'minitest/autorun'
 require 'minitest/focus'

test/test_helper/client_helpers.rb

@@ -15,11 +15,19 @@ def client_stub_responses
       client.stub_responses(:get_queue_url, {
         queue_url: 'https://sqs.us-stubbed-1.amazonaws.com'
       })
+      redrive_policy = JSON.dump({maxReceiveCount: max_receive_count.to_s})
+      client.stub_responses(:get_queue_attributes, {
+        attributes: { 'RedrivePolicy' => redrive_policy }
+      })
     end
 
     def api_requests
       client.api_requests
     end
 
+    def max_receive_count
+      8
+    end
+
   end
 end

test/test_helper/queue_helpers.rb

@@ -7,12 +7,5 @@ def queue_name
       ENV['TEST_QUEUE_NAME']
     end
 
-    def stub_get_queue_attributes(maxReceiveCount: 13)
-      redrive_policy = JSON.dump({maxReceiveCount: maxReceiveCount.to_s})
-      client.stub_responses(:get_queue_attributes, {
-        attributes: { 'RedrivePolicy' => redrive_policy }
-      })
-    end
-
   end
 end